Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "ignoreTypeDefault" option to "type-import-style" #393

Merged
merged 1 commit into from Apr 3, 2019
Merged

feat: add "ignoreTypeDefault" option to "type-import-style" #393

merged 1 commit into from Apr 3, 2019

Conversation

zertosh
Copy link
Contributor

@zertosh zertosh commented Apr 3, 2019

The newly added ignoreTypeDefault option, lets you avoid cases where the
rule would normally complain for import type foo from "..."; when in
"identifier" mode. This is desirable because
import {type default as foo} from '...'; is kinda long, when you would
otherwise prefer import type foo from '...';. Also, type default as foo
conflicts with eslint-plugin-import's import/no-named-default
https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-named-default.md

@gajus gajus merged commit 6748dc5 into gajus:master Apr 3, 2019
@gajus
Copy link
Owner

gajus commented Apr 3, 2019

🎉 This PR is included in version 3.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Apr 3, 2019
@zertosh zertosh deleted the type-import-style-ignore-type-default branch April 3, 2019 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants