Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(requireReturnType): fix async generator bug [ci failure is irrelevant] #387

Merged
merged 1 commit into from Feb 15, 2019

Conversation

jedwards1211
Copy link
Contributor

fix #386

There were no test cases for even sync generators with require-return-type, so I added
those too.

@jedwards1211
Copy link
Contributor Author

jedwards1211 commented Feb 15, 2019

@gajus CI only failed because yarn refuses to install on node 6 since semantic-release requires node >= 8.3. I made a PR #388 to fix this

@jedwards1211 jedwards1211 changed the title fix(requireReturnType): fix async generator bug fix(requireReturnType): fix async generator bug [ci failure is irrelevant] Feb 15, 2019
@gajus gajus merged commit 5adb546 into gajus:master Feb 15, 2019
@gajus
Copy link
Owner

gajus commented Feb 15, 2019

🎉 This PR is included in version 3.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

require-return-type says "must annotate undefined return type" on an async generator function
2 participants