Skip to content

Commit

Permalink
Use linked instead of top level Mocha (#1051)
Browse files Browse the repository at this point in the history
  • Loading branch information
@daffl
daffl committed Oct 10, 2018
1 parent ce49822 commit 7ecc6a7
Show file tree
Hide file tree
Showing 23 changed files with 109 additions and 38 deletions.
65 changes: 56 additions & 9 deletions package-lock.json
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Expand Up @@ -32,7 +32,6 @@
},
"devDependencies": {
"lerna": "^3.4.0",
"mocha": "^5.2.0",
"nyc": "^13.0.1",
"semistandard": "^12.0.1",
"grunt": "^1.0.3",
Expand Down
5 changes: 3 additions & 2 deletions packages/authentication-client/package.json
View file
Expand Up @@ -26,7 +26,7 @@
"node": ">= 6"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"directories": {
"lib": "lib"
Expand All @@ -37,7 +37,8 @@
"dependencies": {
"@feathersjs/errors": "^3.3.4",
"debug": "^4.0.0",
"jwt-decode": "^2.1.0"
"jwt-decode": "^2.1.0",
"mocha": "^5.2.0"
},
"devDependencies": {
"@feathersjs/authentication": "^2.1.11",
Expand Down
3 changes: 2 additions & 1 deletion packages/authentication-jwt/package.json
View file
Expand Up @@ -26,7 +26,7 @@
"node": ">= 6"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"directories": {
"lib": "lib"
Expand All @@ -40,6 +40,7 @@
"lodash.merge": "^4.6.0",
"lodash.omit": "^4.5.0",
"lodash.pick": "^4.4.0",
"mocha": "^5.2.0",
"passport-jwt": "^4.0.0"
},
"devDependencies": {
Expand Down
3 changes: 2 additions & 1 deletion packages/authentication-local/package.json
View file
Expand Up @@ -26,7 +26,7 @@
"node": ">= 6"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"directories": {
"lib": "lib"
Expand All @@ -39,6 +39,7 @@
"bcryptjs": "^2.3.0",
"debug": "^4.0.0",
"lodash": "^4.17.5",
"mocha": "^5.2.0",
"passport-local": "^1.0.0"
},
"devDependencies": {
Expand Down
5 changes: 3 additions & 2 deletions packages/authentication-oauth1/package.json
View file
Expand Up @@ -26,7 +26,7 @@
"node": ">= 6"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"directories": {
"lib": "lib"
Expand All @@ -38,7 +38,8 @@
"@feathersjs/commons": "^3.0.1",
"@feathersjs/errors": "^3.3.4",
"debug": "^4.0.0",
"lodash.merge": "^4.6.0"
"lodash.merge": "^4.6.0",
"mocha": "^5.2.0"
},
"devDependencies": {
"@feathersjs/authentication": "^2.1.11",
Expand Down
5 changes: 3 additions & 2 deletions packages/authentication-oauth2/package.json
View file
Expand Up @@ -26,7 +26,7 @@
"node": ">= 6"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"directories": {
"lib": "lib"
Expand All @@ -39,7 +39,8 @@
"@feathersjs/errors": "^3.3.4",
"@feathersjs/express": "^1.2.7",
"debug": "^4.0.0",
"lodash.merge": "^4.6.1"
"lodash.merge": "^4.6.1",
"mocha": "^5.2.0"
},
"devDependencies": {
"@feathersjs/authentication": "^2.1.11",
Expand Down
3 changes: 2 additions & 1 deletion packages/authentication/package.json
View file
Expand Up @@ -26,7 +26,7 @@
"node": ">= 6"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"directories": {
"lib": "lib"
Expand All @@ -45,6 +45,7 @@
"lodash.omit": "^4.5.0",
"lodash.pick": "^4.4.0",
"long-timeout": "^0.1.1",
"mocha": "^5.2.0",
"ms": "^2.0.0",
"passport": "^0.4.0",
"uuid": "^3.1.0"
Expand Down
3 changes: 2 additions & 1 deletion packages/cli/package.json
View file
Expand Up @@ -28,7 +28,7 @@
"node": ">= 6"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"directories": {
"lib": "lib"
Expand All @@ -42,6 +42,7 @@
"commander": "^2.9.0",
"generator-feathers": "^2.7.1",
"generator-feathers-plugin": "^1.0.1",
"mocha": "^5.2.0",
"semver": "^5.3.0",
"update-notifier": "^2.3.0",
"yeoman-environment": "^2.0.0"
Expand Down
5 changes: 4 additions & 1 deletion packages/client/package.json
View file
Expand Up @@ -23,7 +23,7 @@
"scripts": {
"clean": "../../node_modules/.bin/shx rm -rf dist/ && ../../node_modules/.bin/shx mkdir -p dist",
"version": "npm run build",
"mocha": "../../node_modules/.bin/mocha --opts ../../mocha.opts",
"mocha": "mocha --opts ../../mocha.opts",
"test": "npm run build && npm run mocha",
"build": "npm run clean && npm run webpack",
"build:test": "cd browser && webpack",
Expand Down Expand Up @@ -62,5 +62,8 @@
"webpack": "^4.19.0",
"webpack-merge": "^4.1.4",
"ws": "^6.0.0"
},
"dependencies": {
"mocha": "^5.2.0"
}
}
5 changes: 4 additions & 1 deletion packages/commons/package.json
View file
Expand Up @@ -25,7 +25,7 @@
},
"main": "lib/commons.js",
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"directories": {
"lib": "lib"
Expand All @@ -35,5 +35,8 @@
},
"devDependencies": {
"chai": "^4.1.2"
},
"dependencies": {
"mocha": "^5.2.0"
}
}
5 changes: 3 additions & 2 deletions packages/configuration/package.json
View file
Expand Up @@ -26,7 +26,7 @@
"node": ">= 6"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"semistandard": {
"env": [
Expand All @@ -41,7 +41,8 @@
},
"dependencies": {
"config": "^2.0.0",
"debug": "^4.0.0"
"debug": "^4.0.0",
"mocha": "^5.2.0"
},
"devDependencies": {
"@feathersjs/feathers": "^3.2.3"
Expand Down
5 changes: 3 additions & 2 deletions packages/errors/package.json
View file
Expand Up @@ -29,13 +29,14 @@
"lib": "lib"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"publishConfig": {
"access": "public"
},
"dependencies": {
"debug": "^4.0.0"
"debug": "^4.0.0",
"mocha": "^5.2.0"
},
"devDependencies": {
"@feathersjs/feathers": "^3.2.3",
Expand Down
3 changes: 2 additions & 1 deletion packages/express/package.json
View file
Expand Up @@ -26,7 +26,7 @@
"node": ">= 6"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"directories": {
"lib": "lib"
Expand All @@ -39,6 +39,7 @@
"@feathersjs/errors": "^3.3.4",
"debug": "^4.0.0",
"express": "^4.16.2",
"mocha": "^5.2.0",
"uberproto": "^2.0.0"
},
"devDependencies": {
Expand Down
3 changes: 2 additions & 1 deletion packages/feathers/package.json
View file
Expand Up @@ -27,7 +27,7 @@
"lib": "lib"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts",
"test": "mocha --opts ../../mocha.opts",
"update-version": "node -e \"console.log('module.exports = \\'' + require('./package.json').version + '\\';')\" > lib/version.js",
"version": "npm run update-version"
},
Expand All @@ -41,6 +41,7 @@
"@feathersjs/commons": "^3.0.1",
"debug": "^4.0.0",
"events": "^3.0.0",
"mocha": "^5.2.0",
"uberproto": "^2.0.2"
}
}
3 changes: 2 additions & 1 deletion packages/generator-feathers-plugin/package.json
View file
Expand Up @@ -23,9 +23,10 @@
"url": "git://github.com/feathersjs/feathers.git"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"dependencies": {
"mocha": "^5.2.0",
"yeoman-generator": "^3.0.0"
},
"devDependencies": {
Expand Down
3 changes: 2 additions & 1 deletion packages/generator-feathers/package.json
View file
Expand Up @@ -30,12 +30,13 @@
"node": ">= 6.0.0"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts --timeout 30000"
"test": "mocha --opts ../../mocha.opts --timeout 30000"
},
"dependencies": {
"@feathersjs/jscodeshift": "^0.5.0",
"@feathersjs/tools": "^0.1.7",
"lodash": "^4.17.10",
"mocha": "^5.2.0",
"node-dir": "^0.1.17",
"randomstring": "^1.1.5",
"semver": "^5.5.0",
Expand Down
5 changes: 3 additions & 2 deletions packages/primus-client/package.json
View file
Expand Up @@ -26,7 +26,7 @@
"node": ">= 6.0.0"
},
"scripts": {
"test": "../../node_modules/.bin/mocha --opts ../../mocha.opts"
"test": "mocha --opts ../../mocha.opts"
},
"directories": {
"lib": "lib"
Expand All @@ -35,7 +35,8 @@
"access": "public"
},
"dependencies": {
"@feathersjs/transport-commons": "^4.1.5"
"@feathersjs/transport-commons": "^4.1.5",
"mocha": "^5.2.0"
},
"devDependencies": {
"@feathersjs/commons": "^3.0.1",
Expand Down

2 comments on commit 7ecc6a7

@bertho-zero
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mocha should not rather be in devDependencies?

@daffl
Copy link
Member Author

@daffl daffl commented on 7ecc6a7 Oct 11, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shoot. Thanks for catching that.

Please sign in to comment.