Fix an SVG focusing crash in IE11 #12996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
gaearon
requested changes
Jun 8, 2018
| @@ -82,7 +83,7 @@ export function restoreSelection(priorSelectionInformation) { | |||
| } | |||
| } | |||
|
|
|||
| priorFocusedElem.focus(); | |||
| focusNode(priorFocusedElem); | |||
There was a problem hiding this comment.
Let’s just inline the try/catch here and leave a comment that this is for SVG in IE11.
|
Would a fix like if (typeof priorFocusedElem.focus === 'function') {
priorFocusedElem.focus();
}be sufficient then? |
|
Yes, It's better. |
gaearon
reviewed
Jun 11, 2018
| priorFocusedElem.focus(); | ||
| } catch (e) { | ||
| } else { | ||
| // The SVGElement don't have a focus method in IE11 | ||
| focusNode(priorFocusedElem); |
There was a problem hiding this comment.
Hmm, we don't need this part now, right?
gaearon
approved these changes
Jun 11, 2018
|
Have you verified this fixes the IE11 issue? |
|
@gaearon Yes, this fixed the IE11 issue. |
|
Thanks! |
bors bot
added a commit
to mozilla/delivery-console
that referenced
this pull request
Jun 13, 2018
193: Update dependency react to v16.4.1 r=magopian a=renovate[bot] This Pull Request updates dependency [react](https://github.com/facebook/react) from `v16.4.0` to `v16.4.1` <details> <summary>Release Notes</summary> ### [`v16.4.1`](https://github.com/facebook/react/blob/master/CHANGELOG.md#​1641-June-13-2018) [Compare Source](facebook/react@v16.4.0...v16.4.1) ##### React * You can now assign `propTypes` to components returned by `React.ForwardRef`. ([@​bvaughn] in [#​12911](`facebook/react#12911)) ##### React DOM * Fix a crash when the input `type` changes from some other types to `text`. ([@​spirosikmd] in [#​12135](`facebook/react#12135)) * Fix a crash in IE11 when restoring focus to an SVG element. ([@​ThaddeusJiang] in [#​12996](`facebook/react#12996)) * Fix a range input not updating in some cases. ([@​Illu] in [#​12939](`facebook/react#12939)) * Fix input validation triggering unnecessarily in Firefox. ([@​nhunzaker] in [#​12925](`facebook/react#12925)) * Fix an incorrect `event.target` value for the `onChange` event in IE9. ([@​nhunzaker] in [#​12976](`facebook/react#12976)) * Fix a false positive error when returning an empty `<React.Fragment />` from a component. ([@​philipp-spiess] in [#​12966](`facebook/react#12966)) ##### React DOM Server * Fix an incorrect value being provided by new context API. ([@​ericsoderberghp] in [#​12985](`facebook/react#12985), [@​gaearon] in [#​13019](`facebook/react#13019)) ##### React Test Renderer * Allow multiple root children in test renderer traversal API. ([@​gaearon] in [#​13017](`facebook/react#13017)) * Fix `getDerivedStateFromProps()` in the shallow renderer to not discard the pending state. ([@​fatfisz] in [#​13030](`facebook/react#13030)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
bors bot
added a commit
to mythmon/corsica-tree-status
that referenced
this pull request
Jun 14, 2018
25: Update react monorepo to v16.4.1 r=renovate[bot] a=renovate[bot] This Pull Request renovates the package group "react monorepo". - [react-dom](https://github.com/facebook/react) (`dependencies`): from `16.4.0` to `16.4.1` - [react](https://github.com/facebook/react) (`dependencies`): from `16.4.0` to `16.4.1` # Release Notes <details> <summary>facebook/react</summary> ### [`v16.4.1`](https://github.com/facebook/react/blob/master/CHANGELOG.md#​1641-June-13-2018) [Compare Source](facebook/react@v16.4.0...v16.4.1) ##### React * You can now assign `propTypes` to components returned by `React.ForwardRef`. ([@​bvaughn] in [#​12911](`facebook/react#12911)) ##### React DOM * Fix a crash when the input `type` changes from some other types to `text`. ([@​spirosikmd] in [#​12135](`facebook/react#12135)) * Fix a crash in IE11 when restoring focus to an SVG element. ([@​ThaddeusJiang] in [#​12996](`facebook/react#12996)) * Fix a range input not updating in some cases. ([@​Illu] in [#​12939](`facebook/react#12939)) * Fix input validation triggering unnecessarily in Firefox. ([@​nhunzaker] in [#​12925](`facebook/react#12925)) * Fix an incorrect `event.target` value for the `onChange` event in IE9. ([@​nhunzaker] in [#​12976](`facebook/react#12976)) * Fix a false positive error when returning an empty `<React.Fragment />` from a component. ([@​philipp-spiess] in [#​12966](`facebook/react#12966)) ##### React DOM Server * Fix an incorrect value being provided by new context API. ([@​ericsoderberghp] in [#​12985](`facebook/react#12985), [@​gaearon] in [#​13019](`facebook/react#13019)) ##### React Test Renderer * Allow multiple root children in test renderer traversal API. ([@​gaearon] in [#​13017](`facebook/react#13017)) * Fix `getDerivedStateFromProps()` in the shallow renderer to not discard the pending state. ([@​fatfisz] in [#​13030](`facebook/react#13030)) --- </details> --- This PR has been generated by [Renovate Bot](https://renovatebot.com). Co-authored-by: Renovate Bot <bot@renovateapp.com>
This was referenced Jun 14, 2018
This was referenced Nov 1, 2018
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because #12763