Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle possible null return value for document.defaultValue #13757

Closed
ilias-t opened this issue Oct 1, 2018 · 1 comment
Closed

Handle possible null return value for document.defaultValue #13757

ilias-t opened this issue Oct 1, 2018 · 1 comment

Comments

@ilias-t
Copy link

ilias-t commented Oct 1, 2018

Do you want to request a feature or report a bug?
Bug, specific to react-dom.

What is the current behavior?
There is no null check for when document.defaultValue returns null as is specified as a possible return value in MDN docs.

In browsers, document.defaultView returns the window object associated with a document, or null if none is available.

If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem. Your bug will get fixed much faster if we can run your code and it doesn't have dependencies other than React. Paste the link to your JSFiddle (https://jsfiddle.net/Luktwrdm/) or CodeSandbox (https://codesandbox.io/s/new) example below:
Root cause seems pretty apparent in that we are not handling a possible null value. Will submit a fix shortly.

What is the expected behavior?
Error is not thrown if document.defaultValue returns null.

Which versions of React, and which browser / OS are affected by this issue? Did this work in previous versions of React?
Present on version 16.2.0.

@ilias-t
Copy link
Author

ilias-t commented Oct 1, 2018

Seems to have been addressed in #13650

@ilias-t ilias-t closed this as completed Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant