{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":31927407,"defaultBranch":"main","name":"fboss","ownerLogin":"facebook","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-03-09T23:04:15.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/69631?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1706541559.0","currentOid":""},"activityList":{"items":[{"before":"6f4e9273e234284fe0fb8e509502d7ed766b71a8","after":"18732c91e42fc1a5b89c91664405d81b374fc428","ref":"refs/heads/main","pushedAt":"2024-06-02T16:35:32.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/fb303/commit/4243b6f98f8d951097567cb4b1fb96d0214fb358\nhttps://github.com/facebook/fbthrift/commit/93e7a65a6b3f0eb2df26e871e0f13419e66fc73d\nhttps://github.com/facebook/folly/commit/aea9be346324528157f506c943baea1d849c4c81\nhttps://github.com/facebook/mvfst/commit/b71ab0ecd6067f88d6269bff2e8d9fb1084abc72\nhttps://github.com/facebook/proxygen/commit/f57c1ad880f801483d59094f2924e83719891a7a\nhttps://github.com/facebook/wangle/commit/a24d55c4a9424a93de8fa77ca423d0ff18842071\nhttps://github.com/facebookexperimental/edencommon/commit/901ff933f7d4ee787187b3cf49f25ef4d7ee0aef\nhttps://github.com/facebookexperimental/rust-shed/commit/00e7f6d2af4d3c3f50bb0c8bcd9af01b1faa772a\nhttps://github.com/facebookincubator/fizz/commit/0e1763e07c02c102572bbeab0900c9c34349bfe1\n\nReviewed By: namanahuja\n\nfbshipit-source-id: f999a9a36cdb74e9e4adc6f19d0a4550b9db0a7c","shortMessageHtmlLink":"Updating submodules"}},{"before":"c8d758566322dfa290a2fa28e3034cd983bfee7a","after":"6f4e9273e234284fe0fb8e509502d7ed766b71a8","ref":"refs/heads/main","pushedAt":"2024-06-02T02:22:50.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix --use-shipit\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/852\n\nIt was using the old PHP shipit script\n\nReviewed By: chadaustin\n\nDifferential Revision: D58013009\n\nfbshipit-source-id: 97f0c31b897c04217ca5dd62fbe6cc2a55d280c8","shortMessageHtmlLink":"Fix --use-shipit"}},{"before":"6d1b6d8ca4f761c2a71c7f2980a0efdd9ccbe947","after":"c8d758566322dfa290a2fa28e3034cd983bfee7a","ref":"refs/heads/main","pushedAt":"2024-06-01T16:36:33.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/6ed9232c372ee58f23f31a465ee64047ade74169\nhttps://github.com/facebook/fb303/commit/9b5a5f3b91d3445419628f6958f8e5f9e84b6b46\nhttps://github.com/facebook/fbthrift/commit/51bc3104dd54ae0bb80210e417d1eacc5e7a5989\nhttps://github.com/facebook/folly/commit/93bb6d06fec49ae7a56be5f8eec66c356028fe7d\nhttps://github.com/facebook/mvfst/commit/554c94acdd404f6bf6f1c8ce05448db5ba5f9a96\nhttps://github.com/facebook/proxygen/commit/343db73eabe6a4352c9734bfcaa91d9498f15222\nhttps://github.com/facebook/wangle/commit/ce1e98cb46bcbcac47fb4b226d93bf8e53094e2f\nhttps://github.com/facebookexperimental/edencommon/commit/bdd6748988b0c2ee4fa32398983514865dad757d\nhttps://github.com/facebookexperimental/rust-shed/commit/31a8db9294e99bc424e5fde4dc4426ced37bd062\nhttps://github.com/facebookincubator/fizz/commit/6e67555602f093698b3ee3261a3b02510cd28402\n\nReviewed By: namanahuja\n\nfbshipit-source-id: 338c6322939c9185ca4d330d500ce09c42d2f73f","shortMessageHtmlLink":"Updating submodules"}},{"before":"90313fbb60a0881fb54d4dae76a08dd18228cebb","after":"6d1b6d8ca4f761c2a71c7f2980a0efdd9ccbe947","ref":"refs/heads/main","pushedAt":"2024-06-01T15:19:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Add ghc (#850)\n\nSummary: Pull Request resolved: https://github.com/facebookincubator/zstrong/pull/850\n\nReviewed By: markbt\n\nDifferential Revision: D58011866\n\nfbshipit-source-id: 3c6a8443f7fd9c512837d27162a2399c21eb243c","shortMessageHtmlLink":"Add ghc (#850)"}},{"before":"3625cbb88602116056067a0d6d71429c20abb6d2","after":"90313fbb60a0881fb54d4dae76a08dd18228cebb","ref":"refs/heads/main","pushedAt":"2024-06-01T14:33:09.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"--shared-libs should be a common argument\n\nSummary:\nX-link: https://github.com/facebookincubator/zstrong/pull/848\n\nBecause it should work with `show-inst-dir`, otherwise we can't\ncalculate the right project hash.\n\nReviewed By: chadaustin\n\nDifferential Revision: D58011867\n\nfbshipit-source-id: d8960b4a993efbada8e27584e56976279fcd6b43","shortMessageHtmlLink":"--shared-libs should be a common argument"}},{"before":"43625663410fc66c7982e49d01d50cd37d74d52e","after":"3625cbb88602116056067a0d6d71429c20abb6d2","ref":"refs/heads/main","pushedAt":"2024-06-01T01:27:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fboss_hw_benchmark_config_sync\n\nReviewed By: srikrishnagopu\n\nDifferential Revision: D58039622\n\nfbshipit-source-id: fa412bb83848c7640c0139db71042b7f6d269fd7","shortMessageHtmlLink":"fboss_hw_benchmark_config_sync"}},{"before":"e5a17db8c1dc934352f2bc8210f64fc309565e8e","after":"43625663410fc66c7982e49d01d50cd37d74d52e","ref":"refs/heads/main","pushedAt":"2024-05-31T23:54:41.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Retire HwMacLearningAndNeighborResolution Hw tests\n\nSummary: Retiring the old tests\n\nReviewed By: shri-khare\n\nDifferential Revision: D57952249\n\nfbshipit-source-id: 489928c008e6578fa1c607eaf1756291bc1ca3db","shortMessageHtmlLink":"Retire HwMacLearningAndNeighborResolution Hw tests"}},{"before":"75a9b98206804fa59cdda846ab6b01152abbcd3e","after":"e5a17db8c1dc934352f2bc8210f64fc309565e8e","ref":"refs/heads/main","pushedAt":"2024-05-31T22:39:27.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"fboss_link_test_config_sync\n\nDifferential Revision: D58036092\n\nfbshipit-source-id: d3d878e189ea3ef91127ec2c4bc09f331d58c390","shortMessageHtmlLink":"fboss_link_test_config_sync"}},{"before":"e285eedc08c3c262a2054793fc0f9e4a19561b4e","after":"75a9b98206804fa59cdda846ab6b01152abbcd3e","ref":"refs/heads/main","pushedAt":"2024-05-31T22:34:10.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"move eventor core to 0 for J3\n\nSummary: As titled, move eventor core to 0 for J3 to enable changes from D57679590.\n\nReviewed By: shri-khare, harshitgulati18\n\nDifferential Revision: D58031591\n\nfbshipit-source-id: 5905b70eb50e90cfbe01b83a310ee05996c2dba8","shortMessageHtmlLink":"move eventor core to 0 for J3"}},{"before":"a2bb17813867617148758c046a1ac61c1facd05a","after":"e285eedc08c3c262a2054793fc0f9e4a19561b4e","ref":"refs/heads/main","pushedAt":"2024-05-31T22:07:30.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Gather All PRBS Stats in One Table in FBOSS2 Show Interface PRBS Stats\n\nSummary: For cleaner FBOSS2 CLI output, I put all PRBS stats in one table by adding interface and component column, instead of presenting tables for each interface+component pair. I also presented a single \"Time Since Last Update\" across all fetched PRBS stats above the table.\n\nReviewed By: harshitgulati18\n\nDifferential Revision: D58003830\n\nfbshipit-source-id: 173386069dd3c2f9a15357ee53f306babfb7d788","shortMessageHtmlLink":"Gather All PRBS Stats in One Table in FBOSS2 Show Interface PRBS Stats"}},{"before":"57b1b66838e3b28df94e9ca41b1a65b83e82c12b","after":"a2bb17813867617148758c046a1ac61c1facd05a","ref":"refs/heads/main","pushedAt":"2024-05-31T22:02:26.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"update version pp flags for tajo sdk\n\nSummary: As titled, update version pp flags for Tajo SDK\n\nReviewed By: shri-khare\n\nDifferential Revision: D58000447\n\nfbshipit-source-id: b880704ff6fd5996f43047b42261000750eddcf5","shortMessageHtmlLink":"update version pp flags for tajo sdk"}},{"before":"098f3785f5a07a69d9a4f13b03d941f5760ae5c3","after":"57b1b66838e3b28df94e9ca41b1a65b83e82c12b","ref":"refs/heads/main","pushedAt":"2024-05-31T21:54:21.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove Lassen References from fboss github cmake files\n\nSummary: Removing Lassen usage from the fboss repo to reduce build times both internally and for OSS. This diff removes references from github cmake files.\n\nReviewed By: srikrishnagopu\n\nDifferential Revision: D58016057\n\nfbshipit-source-id: 6e4ab5e5571f5e33572a364981e5da35b1f768e4","shortMessageHtmlLink":"Remove Lassen References from fboss github cmake files"}},{"before":"0499aeb2085fcb8bb45d82db41a1ea5550a30c14","after":"098f3785f5a07a69d9a4f13b03d941f5760ae5c3","ref":"refs/heads/main","pushedAt":"2024-05-31T16:35:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/f14410f0bc45fd1c53eb56698fb5bcfac42758f7\nhttps://github.com/facebook/fb303/commit/17976a6492a1b923a5cebb9b1d0003c24703ffd4\nhttps://github.com/facebook/fbthrift/commit/b0901104ac78a24cbc2e017498035329327b76be\nhttps://github.com/facebook/folly/commit/4a96830b790513091f78aee6cc943a669713e855\nhttps://github.com/facebook/mvfst/commit/433d82d61413e323a553ab4586727017577a4d23\nhttps://github.com/facebook/proxygen/commit/9c5b517d6dcf8884c17e73e45458f2823734471e\nhttps://github.com/facebook/wangle/commit/8d32d1bf554777d9fde3eb2fb1019c2b51209a14\nhttps://github.com/facebookexperimental/edencommon/commit/8e50a2ee6169c4d9ec39a0bb7c3c6f61b033994f\nhttps://github.com/facebookexperimental/rust-shed/commit/e1cd2048f28c7a04bbd7f597b07b8e16206ffbf8\nhttps://github.com/facebookincubator/fizz/commit/824cbbe249ebb944edb97e348caea91a4d2ee750\n\nReviewed By: namanahuja\n\nfbshipit-source-id: 6a32b88b628eab7a8d8e75ec93ad270658c9f3eb","shortMessageHtmlLink":"Updating submodules"}},{"before":"df057a782467307a04c0919bf52d8c55156a9cc6","after":"0499aeb2085fcb8bb45d82db41a1ea5550a30c14","ref":"refs/heads/main","pushedAt":"2024-05-31T06:32:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"typo on hw_write_behavior\n\nSummary: As titlted, typo on hw_write_behavior\n\nReviewed By: harshitgulati18\n\nDifferential Revision: D58002162\n\nfbshipit-source-id: e1d914f20a91877cb1b175d7a6c7df3163977364","shortMessageHtmlLink":"typo on hw_write_behavior"}},{"before":"ca553ac943bfb43d96de03647d51f16fec4f3415","after":"df057a782467307a04c0919bf52d8c55156a9cc6","ref":"refs/heads/main","pushedAt":"2024-05-31T04:07:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Hw agent to deconstruct thrift server\n\nSummary:\nAs titled. In agent tests we discovered that TH devices are more likely to encounter memory leak after stopping thrift server -\nThe recommended sequence is\n1. Stop thrift server\n2. Deconstruct thrift server such that all threads will be join\n3. exit\n\nExplicitly wait for thrift server to be deconstructed before exiting hw agent.\n\nReviewed By: msomasundaran\n\nDifferential Revision: D57953356\n\nfbshipit-source-id: 62e87eb26063c1e68b9239ae600898994f541921","shortMessageHtmlLink":"Hw agent to deconstruct thrift server"}},{"before":"e5b5779e0e9b6693da6d206b0c201d3b97c0b88a","after":"ca553ac943bfb43d96de03647d51f16fec4f3415","ref":"refs/heads/main","pushedAt":"2024-05-31T02:18:23.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"enable sflow system port id computation for kodiak3\n\nSummary:\nAs titled, enable sflow system port id computation for kodiak3.\n\nAll recent Cisco SDKs will support system port ID extension and Cisco has validated this patch,\n\nReviewed By: nivinl\n\nDifferential Revision: D57972852\n\nfbshipit-source-id: d6bc916d47f1420b2cbc290ec51a78b444ee7b29","shortMessageHtmlLink":"enable sflow system port id computation for kodiak3"}},{"before":"f3fde6d82fa6a553c898228c24a2daf25dcdd9dd","after":"e5b5779e0e9b6693da6d206b0c201d3b97c0b88a","ref":"refs/heads/main","pushedAt":"2024-05-30T23:47:42.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix operDelta sync stop error in hw ensemble\n\nSummary: D57871407 split thrift syncer shutdown to two parts in hw agent. A similar change is needed in hw ensemble also since we have few tests which perform multiswitch functionality in hw tests as well.\n\nDifferential Revision: D57993201\n\nfbshipit-source-id: 2f5eced2be00a6737b006d72dd453482225c17e4","shortMessageHtmlLink":"Fix operDelta sync stop error in hw ensemble"}},{"before":"f714f1e17b3a1126533b4b5964b544c23c86da9b","after":"f3fde6d82fa6a553c898228c24a2daf25dcdd9dd","ref":"refs/heads/main","pushedAt":"2024-05-30T23:12:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix disconnectedSubscribers counter for subs not expected to connect\n\nSummary:\nFor subscriber clientId that has 0 expected subscriptions, fix initial value\nof disconnected_subscribers counter to 0.\n\nReviewed By: peygar\n\nDifferential Revision: D57973854\n\nfbshipit-source-id: efc7dc478b1b04496300b6215274c7bbee00886c","shortMessageHtmlLink":"Fix disconnectedSubscribers counter for subs not expected to connect"}},{"before":"9117ee45eed345101fd9c471ac6d871d014522ba","after":"f714f1e17b3a1126533b4b5964b544c23c86da9b","ref":"refs/heads/main","pushedAt":"2024-05-30T21:56:25.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"add port toggle workaround for TH5\n\nSummary: This workaround was removed in D49119095, but turns out we still need it in brcm-sai 10.2 version. Add this workaround back while continue debugging it with broadcom\n\nReviewed By: rongchunzhou\n\nDifferential Revision:\nD57972820\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: cd5877c432a7f407838e5e29216903b2dd352425","shortMessageHtmlLink":"add port toggle workaround for TH5"}},{"before":"637ca31b4393a860840116a014a056b97f9ed971","after":"9117ee45eed345101fd9c471ac6d871d014522ba","ref":"refs/heads/main","pushedAt":"2024-05-30T20:08:14.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Fix HW Write Behavior for Multiswitch Agent HW Test Runs\n\nSummary: To properly integrate zero SDK check with agent hw testing in multiswitch mode, I fetch the HwWriteBehavior from StateOperDelta in HwAgent and set the HW write behavior RAII object before applying initial state.\n\nReviewed By: zechengh09\n\nDifferential Revision:\nD56329330\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: efe081f70d7301506fb24e20ab34f704754e96ed","shortMessageHtmlLink":"Fix HW Write Behavior for Multiswitch Agent HW Test Runs"}},{"before":"d5e21a9f7a3753e17bf51e238501ff98416b2e0c","after":"637ca31b4393a860840116a014a056b97f9ed971","ref":"refs/heads/main","pushedAt":"2024-05-30T18:30:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"OSS target voq route scale benchmark\n\nSummary: As titled.\n\nReviewed By: jasmeetbagga\n\nDifferential Revision: D57499375\n\nfbshipit-source-id: f60e0ddf872620d75c4b840779dec2aaa4117342","shortMessageHtmlLink":"OSS target voq route scale benchmark"}},{"before":"7019bd9605838523400a25c62fa2bb1d12a85baa","after":"d5e21a9f7a3753e17bf51e238501ff98416b2e0c","ref":"refs/heads/main","pushedAt":"2024-05-30T17:12:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Route scale benchmark for voq\n\nSummary:\nAs titled. Add benchmark to measure\n\n1. Configure remote system ports for all 144 nodes.\n2. Configure 8x512 wide ECMP routes.\n\nReviewed By: jasmeetbagga\n\nDifferential Revision:\nD57289789\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: cb53a0839f17fbaf7a86ab7a249751741b603d17","shortMessageHtmlLink":"Route scale benchmark for voq"}},{"before":"9c0333aa081f472a5055d1baea02dfd675c8c34e","after":"7019bd9605838523400a25c62fa2bb1d12a85baa","ref":"refs/heads/main","pushedAt":"2024-05-30T17:06:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"properly update route classID when nexthop is resolved/unresolved\n\nSummary:\nCurrently, route classID is not properly updated when nexthop is resolved or unresolved. This could cause wrong classID 2 assigned even when route is resolved and trap all matching packets to cpu, see S390808.\n\nThis diff resolves this issue by 1) enhancing HwRouteTest.verifyCpuRouteChange to reproduce the wrong behavior in S390808; 2) enhancing SaiRouteManager to properly update classID when nexthop is resolved or unresolved.\n\nNote: compared with previous D57077469 (backed out later), this diff also takes route classID update from switch state into account (for queue-per-host feature use case), see \"existingManagedRouteNextHop->setMetadata()\".\n\nReviewed By: srikrishnagopu\n\nDifferential Revision:\nD57819396\n\nPrivacy Context Container: L1125642\n\nfbshipit-source-id: eeda2d41dcfc6d5ffbec2f693942ca4900c13f60","shortMessageHtmlLink":"properly update route classID when nexthop is resolved/unresolved"}},{"before":"570b044f2564f0e5caadab186d4758efefb7c8a2","after":"9c0333aa081f472a5055d1baea02dfd675c8c34e","ref":"refs/heads/main","pushedAt":"2024-05-30T16:58:37.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Helper api to get remote switch Id\n\nSummary: As titled - used in stacked diffs\n\nReviewed By: srikrishnagopu\n\nDifferential Revision: D57896402\n\nfbshipit-source-id: ef38e4804378e5d68e37f35ba1565d46cb22c84c","shortMessageHtmlLink":"Helper api to get remote switch Id"}},{"before":"e6dd9eac3bf27ef59eb6d84e14f80157126e3575","after":"570b044f2564f0e5caadab186d4758efefb7c8a2","ref":"refs/heads/main","pushedAt":"2024-05-30T16:36:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Updating submodules\n\nSummary:\nGitHub commits:\n\nhttps://github.com/facebook/buck2-prelude/commit/d0f31fd547ac9edbe29b5dba3e3850aba5b102f1\nhttps://github.com/facebook/fb303/commit/c2836e2e83e98efbdd406c925a2cb19d3d8fac0f\nhttps://github.com/facebook/fbthrift/commit/0a8f857e877f62ef818a39e91bf0e6f817d41e44\nhttps://github.com/facebook/folly/commit/6a9e081bc58bf9a77376ce79c5fc7f642249afe8\nhttps://github.com/facebook/mvfst/commit/e58cc1037337c95788c71097aa23b8a3d3192415\nhttps://github.com/facebook/proxygen/commit/7e15e82fa0c43dabe7d11e0a37b68d2cda9e6372\nhttps://github.com/facebook/wangle/commit/e824a8513b21ba0474fe6358b22d518bc588c7a7\nhttps://github.com/facebookexperimental/edencommon/commit/c4658277baa7df97520c60aa505816e25a8c4556\nhttps://github.com/facebookexperimental/rust-shed/commit/d02f571cd5d5bcf127dfd6331d766abb03e3da66\nhttps://github.com/facebookincubator/fizz/commit/6a7321c406ee7bc8bc0e1d1cc42cb9f063318a0b\n\nReviewed By: namanahuja\n\nfbshipit-source-id: a9262d09ded5e3f875e18ad45be1879e4841abca","shortMessageHtmlLink":"Updating submodules"}},{"before":"8a980892cffc85529a41c62e7081e4abd537d637","after":"e6dd9eac3bf27ef59eb6d84e14f80157126e3575","ref":"refs/heads/main","pushedAt":"2024-05-30T13:31:37.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Use withCancellation apis for agent ipc stream/sink\n\nSummary: On IPC streams/sinks, the consumer can request cancellation of further data when it exits. Using the apis with cancellation for sinks on sw agent and stream on hw agent/\n\nDifferential Revision: D57871469\n\nfbshipit-source-id: 43acf789c15ebfefad0e839befce4da9241fd992","shortMessageHtmlLink":"Use withCancellation apis for agent ipc stream/sink"}},{"before":"873f881e4d9015770fefd96d047aa4d0609b444b","after":"8a980892cffc85529a41c62e7081e4abd537d637","ref":"refs/heads/main","pushedAt":"2024-05-30T06:37:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Remove unused-but-set variables in external/libtorrent-fbpkg/src/utp_stream.cpp +5\n\nSummary:\nThis diff removes a variable that was set, but which was not used.\n\nLLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused but set variables often indicate a programming mistake, but can also just be unnecessary cruft that harms readability and performance.\n\nRemoving this variable will not change how your code works, but the unused variable may indicate your code isn't working the way you thought it was. If you feel the diff needs changes before landing, **please commandeer** and make appropriate changes: there are hundreds of these and responding to them individually is challenging.\n\nFor questions/comments, contact r-barnes.\n\n - If you approve of this diff, please use the \"Accept & Ship\" button :-)\n\nReviewed By: palmje, Orvid\n\nDifferential Revision: D57761241\n\nfbshipit-source-id: 633dfa0e38adb8d93aab1c15bf77de7e8244c9d5","shortMessageHtmlLink":"Remove unused-but-set variables in external/libtorrent-fbpkg/src/utp_…"}},{"before":"da2747942986a3942715bc9b98654d8ba71710bd","after":"873f881e4d9015770fefd96d047aa4d0609b444b","ref":"refs/heads/main","pushedAt":"2024-05-30T06:31:17.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Start pulling up multi-dsf nodes test - addTwoDsfNodesTest\n\nSummary: As titled\n\nReviewed By: zechengh09\n\nDifferential Revision: D57895250\n\nfbshipit-source-id: 48007034163633edae6d814fd15cbc7533816724","shortMessageHtmlLink":"Start pulling up multi-dsf nodes test - addTwoDsfNodesTest"}},{"before":"189ddb654f5e5f3e14f80148dd8e9f861ff5feec","after":"da2747942986a3942715bc9b98654d8ba71710bd","ref":"refs/heads/main","pushedAt":"2024-05-30T05:34:35.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Provide helper to schedule state update in event base thread\n\nSummary:\nAs titled. During the initial attempt of remote ECMP programming, we noticed the race condition of remote intf updates in RIB vs. route programming from BGP.\n\nImagine the following scenario\n1. DsfSubscriber receives update from another RDSW, scheduling update.\na. `stateUpdate()` will take the `pendingUpdates` lock, then\nb. it will try to update RIB within ribUpdateThread in blocking manner.\n\n2. Agent receives route programming from BGP. Route update wrapper will\na. Take ribUpdateThread to compute route updates in FIB\nb. `stateUpdate()` to take the `pendingUpdates` lock.\n\nBoth threads are trying to take lock in reverse direction, hence causing deadlock.\n\nTo mitigate this, plus to support rollback of DsfSubscriber, we decided to have Dsf updates and FIB update in the same transaction. If any update failed to applied in the hardware, we would be able to rollback both of the updates.\n\nImplementation wise, the update can be queued in ribUpdateThread, such that the lock sequence will be the same as route update (scenario 2 above).\n\nReviewed By: shri-khare\n\nDifferential Revision: D57918119\n\nfbshipit-source-id: ac1d18c57c397a052a687d2b680bb778a08de3a4","shortMessageHtmlLink":"Provide helper to schedule state update in event base thread"}},{"before":"5d49f4fe291a9d4024f1caf46d91c4289c2e1fa6","after":"189ddb654f5e5f3e14f80148dd8e9f861ff5feec","ref":"refs/heads/main","pushedAt":"2024-05-30T05:06:58.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"facebook-github-bot","name":"Facebook Community Bot","path":"/facebook-github-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/6422482?s=80&v=4"},"commit":{"message":"Create 128 nodes for J3 as EDSW config is not ready\n\nSummary: As titled. Currently debugging some issues with 144 nodes - fallback to 128 to unblock scale testing.\n\nReviewed By: srikrishnagopu\n\nDifferential Revision: D57885234\n\nfbshipit-source-id: 08f528e53b46bb517ec5bd45cb149b54f270246c","shortMessageHtmlLink":"Create 128 nodes for J3 as EDSW config is not ready"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEWkKogwA","startCursor":null,"endCursor":null}},"title":"Activity · facebook/fboss"}