Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A question about the type of the origin option value. #271

Open
annahxxl opened this issue Jul 5, 2022 · 3 comments
Open

A question about the type of the origin option value. #271

annahxxl opened this issue Jul 5, 2022 · 3 comments
Labels
docs

Comments

@annahxxl
Copy link

annahxxl commented Jul 5, 2022

If you put an array in the origin option as shown below, the access-control-allow-origin value is not created in the header. If it's a string type, it works fine. Is there a way to pass an array?

스크린샷 2022-07-05 09 29 17
@dougwilson
Copy link
Contributor

Yes, this is expected. The special asterisk does not make sense to include in the array, and is only supported as a single value. We'll get the docs updated around this for you 👍

@dougwilson dougwilson added the docs label Jul 5, 2022
@annahxxl
Copy link
Author

annahxxl commented Jul 5, 2022

@dougwilson Thank you :)

@dhananjaysa92
Copy link

looking into this issue

dhananjaysa92 pushed a commit to dhananjaysa92/cors that referenced this issue Oct 28, 2022
(fix): readme updated for expressjs#271 origin option for *
fb69c8a
@dhananjaysa92 dhananjaysa92 mentioned this issue Oct 28, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dougwilson @annahxxl @dhananjaysa92