Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: reintroduce misspelling in valid-typeof example #9753

Merged
merged 1 commit into from Dec 22, 2017

Conversation

not-an-aardvark
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)

This example is intended to be an invalid typeof string, to illustrate that the rule reports an error if the user makes a typo like this. However, the spelling was inadvertently corrected in aedae9d, so the documentation is now incorrect (it says that valid-typeof reports an error for that code, when in fact it does not).

This commit effectively reverts aedae9d.

Is there anything you'd like reviewers to focus on?

Nothing in particular

This example is intended to be an invalid `typeof` string, to illustrate that the rule reports an error if the user makes a typo like this. However, the spelling was inadvertently corrected in aedae9d, so the documentation is now incorrect (it says that `valid-typeof` reports an error for that code, when in fact it does not).
@not-an-aardvark not-an-aardvark added the documentation Relates to ESLint's documentation label Dec 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants