Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: avoid adding globals when an env is used with false (fixes #9202) #9203

Merged
merged 2 commits into from Sep 3, 2017

Conversation

not-an-aardvark
Copy link
Member

@not-an-aardvark not-an-aardvark commented Sep 2, 2017

What is the purpose of this pull request? (put an "X" next to item)

[x] Bug fix (#9202)

What changes did you make? (Give an overview)

This fixes a regression introduced in f005e24 (merged as part of 60c5148) where globals would get added to environments when the env was set to false in a config file. (The globals would not get added if the env was omitted).

I had originally assumed this was a dead code path because it wasn't covered in any tests (and I had thought environments with env: false where stripped out of the config beforehand). However, it turns out that we just didn't have tests for this case.

Is there anything you'd like reviewers to focus on?

Nothing in particular

This fixes a regression introduced in f005e24 (merged as part of 60c5148) where globals would get added to environments even when the env was set to `false` in a config file.
@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features patch candidate This issue may necessitate a patch release in the next few days regression Something broke labels Sep 2, 2017
@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mysticatea, @gyandeeps and @nzakas to be potential reviewers.

@kgryte
Copy link

kgryte commented Sep 2, 2017

@not-an-aardvark Thanks for the quick turnaround!

@eslintbot
Copy link

LGTM

@ilyavolodin ilyavolodin merged commit cb74b87 into master Sep 3, 2017
@not-an-aardvark not-an-aardvark deleted the fix-env-false branch September 3, 2017 20:55
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Mar 3, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Mar 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly core Relates to ESLint's core APIs and features patch candidate This issue may necessitate a patch release in the next few days regression Something broke
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants