Fix: avoid adding globals when an env is used with false
(fixes #9202)
#9203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Bug fix (#9202)
What changes did you make? (Give an overview)
This fixes a regression introduced in f005e24 (merged as part of 60c5148) where globals would get added to environments when the env was set to
false
in a config file. (The globals would not get added if the env was omitted).I had originally assumed this was a dead code path because it wasn't covered in any tests (and I had thought environments with
env: false
where stripped out of the config beforehand). However, it turns out that we just didn't have tests for this case.Is there anything you'd like reviewers to focus on?
Nothing in particular