Chore: enable eslint-plugin/test-case-property-ordering. #9040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aladdin-add, thanks for your PR! By analyzing the history of the files in this pull request, we identified @not-an-aardvark, @nzakas and @mysticatea to be potential reviewers. |
gyandeeps
approved these changes
Jul 29, 2017
not-an-aardvark
suggested changes
Jul 30, 2017
There was a problem hiding this comment.
Temporarily requesting changes because this fix modifies the whitespace between properties, which can result in strange formatting (see eslint-community/eslint-plugin-eslint-plugin#32).
aladdin-add
force-pushed
the
test-case-property-ordering
branch
from
bfa1361
to
623d75e
Compare
|
LGTM |
aladdin-add
force-pushed
the
test-case-property-ordering
branch
from
623d75e
to
87fe270
Compare
|
LGTM |
|
@not-an-aardvark fixed. |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
the default order is ['code', 'output', 'options', 'parserOptions', 'errors'].
Is there anything you'd like reviewers to focus on?