Chore: enable no-multiple-empty-lines on ESLint codebase #8694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @gyandeeps, @mysticatea and @nzakas to be potential reviewers. |
|
This section of our coding conventions suggests we should set the rule to two blank lines. Not sure how closely we might be following it, though. |
not-an-aardvark
force-pushed
the
no-multiple-empty-lines
branch
from
c212b19
to
c40a65c
Compare
|
LGTM |
|
Thanks for pointing that out, updated to enforce at most 2 blank lines within a file instead of 1. |
gyandeeps
approved these changes
Jun 7, 2017
soda0289
approved these changes
Jun 7, 2017
This was referenced Jun 23, 2017
This was referenced Jul 7, 2017
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain:
What changes did you make? (Give an overview)
This enables
no-multiple-empty-lineson the ESLint codebase.(refs #8679 (comment))
Is there anything you'd like reviewers to focus on?
I configured the rule to warn when more than 1 consecutive line appears in the middle of a file. Is this too strict? If so, I can change it to 2 (the default), which reports fewer existing problems.