Update: fix false positive/negative of yoda rule (fixes #7676) #7695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysticatea
added
accepted
|
@mysticatea, thanks for your PR! By analyzing the history of the files in this pull request, we identified @btmills, @vitorbal and @not-an-aardvark to be potential reviewers. |
|
LGTM |
platinumazure
requested changes
Dec 4, 2016
|
LGTM |
|
@platinumazure Thank you! |
btmills
requested changes
Dec 6, 2016
There was a problem hiding this comment.
Just the one request for the JSDoc comment, otherwise LGTM. Thanks @mysticatea!
| @@ -54,13 +54,15 @@ function looksLikeLiteral(node) { | |||
| /** | |||
| * Attempts to derive a Literal node from nodes that are treated like literals. | |||
| * @param {ASTNode} node Node to normalize. | |||
| * @param {number} [defaultValue] The default value to be returned if the node | |||
| * is not a Literal. | |||
| * @returns {ASTNode} The original node if the node is already a Literal, or a | |||
| * normalized Literal node with the negative number as the | |||
| * value if the node represents a negative number literal, | |||
| * otherwise null if the node cannot be converted to a | |||
| * normalized literal. | |||
There was a problem hiding this comment.
Can you update the return value description to note when it will return the default value?
There was a problem hiding this comment.
Thank you, I updated the JSDoc comment.
|
LGTM |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Bug fix (template)
See #7676 for the template.
What changes did you make? (Give an overview)
The
yodarule has a false positive and a false negative.This PR fixes those bugs.
c62b847 fixed the false negative about computed properties in the range check.
The
yodarule has been handlinga.banda[b]as the same then it determines the condition is a range check wrongly. As the result, it should warn the0 <= a.bbut does not warn it. After this PR is applied, theyodarule will warn the0 <= a.bcorrectly. (semver-minor)bf9982f fixed the false positive about variables in the range check.
The
yodarule has not been handling0 <= index && index < list.lengthas a range check wrongly. As the result, it should not warn0 <= indexbut warns it. After this PR is applied, theyodarule will ignore the0 <= index && index < list.lengthcorrectly. (semver-patch)Is there anything you'd like reviewers to focus on?
Nothing in particular.