Update: add indent options for array and object literals (fixes #7473)

[not-an-aardvark]

What is the purpose of this pull request? (put an "X" next to item)

[x] Changes an existing rule

See #7473

What changes did you make? (Give an overview)

This adds an ArrayExpression and ObjectExpression option to the indent rule, as described in #7473.

Is there anything you'd like reviewers to focus on?

Nothing in particular.

[eslintbot]

LGTM

[mention-bot]

@not-an-aardvark, thanks for your PR! By analyzing the history of the files in this pull request, we identified @vitorbal, @alecharmon and @gyandeeps to be potential reviewers.

[mysticatea]

Incidentally, is typeof checks unnecessary for ObjectExpression differently to CallExpression?

[not-an-aardvark]

Yes, because CallExpression indentation is ignored by default, so the default value of options.CallExpression.arguments is null. However, ArrayExpression and ObjectExpression indentations are not ignored by default, so the default values of options.ArrayExpression and options.ObjectExpression are 1.

[mysticatea]

I got it. Thank you for the explanation.
Actually, "first" * indentSize was in mind and I had forgotten that options.CallExpression.arguments can be null.

[mysticatea]

Thank you for this PR!
But, there are cases that it clashes.

[mysticatea]

This seems to throw TypeError if there are empty objects/arrays.

[eslintbot]

LGTM

[mysticatea]

LGTM, thank you!

[larionov]

I tried to make it work with with indentation like this but had no success. Do you think this is even possible?

export default angular.module('foo', [
        module1,
        module2,
        module3
    ])
    .directive('bar', barDirective);

I have a rule set like this, and tried different values of ArrayExpression and MemberExpression, no luck.

"indent": [2, 4, { "SwitchCase": 1, "MemberExpression": 1, "ArrayExpression": 1}]

[not-an-aardvark]

@larionov The correct indentation for that case would be:

export default angular.module('foo', [
        module1,
        module2,
        module3
])
    .directive('bar', barDirective);

or alternatively you could put the .directive call on the same line:

export default angular.module('foo', [
        module1,
        module2,
        module3
]).directive('bar', barDirective);

Since the array after foo is opened on a line with an indentation of 0, it should also be closed on a line with an indentation of 0.

[larionov]

@not-an-aardvark I use http://jsbeautifier.org/ plugin to format my code automatically and it formats this code like in my first example, so I thought that was somewhat generally accepted. But anyway I already formatted all the code like in your first example, not sure how will second one will go with huge lists of directives.

[mysticatea]

Just linked to #4081 since it's similar topic.

[NicholasBoll]

This PR seems to have broken ObjectExpression default. It used to be 1 and now it is "first". So either the documentation is wrong (no longer default 1) or the code is wrong. We had our CI suddenly fail with indentation errors with object expressions shortly after the 3.12.0 release.

Our configuration for indent is:

"indent" : [2, 2, {"SwitchCase": 1}],

[gyandeeps]

@NicholasBoll Can you please open a new issue with what u r seeing. Thanks