Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update broken link #7490

Merged
merged 1 commit into from Oct 31, 2016
Merged

Update broken link #7490

merged 1 commit into from Oct 31, 2016

Conversation

Devinsuit
Copy link

@Devinsuit Devinsuit commented Oct 30, 2016 •
edited

Fix broken link

@mention-bot
Copy link

@Devinsuit, thanks for your PR! By analyzing the history of the files in this pull request, we identified @nzakas, @vitorbal and @shvaikalesh to be potential reviewers.

@eslintbot
Copy link

Thanks for the pull request, @Devinsuit! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@Devinsuit Devinsuit mentioned this pull request Oct 30, 2016
Closed
not-an-aardvark
not-an-aardvark approved these changes Oct 30, 2016
View reviewed changes
Copy link
Member

@not-an-aardvark not-an-aardvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@not-an-aardvark not-an-aardvark added the documentation Relates to ESLint's documentation label Oct 30, 2016
platinumazure
platinumazure approved these changes Oct 30, 2016
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this!

@ilyavolodin ilyavolodin merged commit 8ba68a3 into eslint:master Oct 31, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@not-an-aardvark not-an-aardvark not-an-aardvark approved these changes

Assignees
No one assigned
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@Devinsuit @mention-bot @eslintbot @platinumazure @not-an-aardvark @ilyavolodin @jquerybot