Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent spacing inside block comment #6768

Merged
merged 1 commit into from Jul 26, 2016
Merged

Fix inconsistent spacing inside block comment #6768

merged 1 commit into from Jul 26, 2016

Conversation

bjacobel
Copy link
Contributor

What issue does this pull request address?
Doc-only pull request, no accepted issue

What changes did you make? (Give an overview)
Other block comments in this file follow the pattern of a space after the opening /* and before the closing */; this one was spaced inconsistently so I modified it to match the spacing shown on the others.

Is there anything you'd like reviewers to focus on?
Nope, should be a quick one.

@eslintbot
Copy link

Thanks for the pull request, @bjacobel! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@mention-bot
Copy link

@bjacobel, thanks for your PR! By analyzing the annotation information on this pull request, we identified @roadhump, @nzakas and @pedrottimark to be potential reviewers

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@eslintbot
Copy link

Thanks for the pull request, @bjacobel! I took a look to make sure it's ready for merging and found some changes are needed:

  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

Other block comments in this file follow the pattern of a space after the opening `/*` and before the closing `*/`; this one was spaced inconsistently so I modified it to match the spacing shown on the others.
@eslintbot
Copy link

LGTM

@alberto
Copy link
Member

alberto commented Jul 26, 2016

LGTM. Thanks for contributing.

@alberto alberto merged commit 628aae4 into eslint:master Jul 26, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants