Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Remove support for Node v5 (fixes #6743) #6744

Merged
merged 1 commit into from Jul 22, 2016
Merged

Conversation

alberto
Copy link
Member

@alberto alberto commented Jul 22, 2016

What issue does this pull request address?
#6743

What changes did you make? (Give an overview)
Remove Node v5 from our CI

Is there anything you'd like reviewers to focus on?
No

@mention-bot
Copy link

@alberto, thanks for your PR! By analyzing the annotation information on this pull request, we identified @gyandeeps, @nzakas and @lo1tuma to be potential reviewers

@eslintbot
Copy link

LGTM

@ilyavolodin
Copy link
Member

LGTM

@ilyavolodin ilyavolodin merged commit 181b26a into master Jul 22, 2016
@nzakas
Copy link
Member

nzakas commented Jul 25, 2016

Hmmm, I don't think we should have done this. We can't drop support for Node 5 without a major release, and there's no harm in continuing to test on the CI.

@alberto alberto deleted the issue6743 branch August 2, 2016 01:08
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants