Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct grammar in object-curly-newline reports (fixes #6725) #6728

Merged
merged 1 commit into from Jul 23, 2016

Conversation

vitorbal
Copy link
Member

What issue does this pull request address?
Typo in the error report messages of object-curly-newline (#6725).

What changes did you make? (Give an overview)
Fixed the typo and adjusted the tests.

Is there anything you'd like reviewers to focus on?
Should we also remove the "this" in the sentence? i.e.:
Unexpected line break after this opening brace.
vs.
Unexpected line break after opening brace.

@mention-bot
Copy link

@vitorbal, thanks for your PR! By analyzing the annotation information on this pull request, we identified @mysticatea, @nzakas and @pedrottimark to be potential reviewers

@eslintbot
Copy link

LGTM

@mysticatea
Copy link
Member

Thank you very much!

@vitorbal
Copy link
Member Author

@mysticatea no problem at all :)

@ilyavolodin
Copy link
Member

LGTM, but waiting another day for others to look

@nzakas
Copy link
Member

nzakas commented Jul 23, 2016

Lgym

@nzakas nzakas merged commit 106e40b into eslint:master Jul 23, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants