Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: fix .gitignore for vscode (refs #6383) #6720

Merged
merged 1 commit into from Jul 21, 2016

Conversation

mysticatea
Copy link
Member

I'm sorry, I had suggested a wrong file name in #6383.
This PR corrects the name of a setting file name in .gitignore.

@mention-bot
Copy link

@mysticatea, thanks for your PR! By analyzing the annotation information on this pull request, we identified @vitorbal, @nzakas and @ilyavolodin to be potential reviewers

@eslintbot
Copy link

LGTM

@vitorbal
Copy link
Member

LGTM!

@alberto
Copy link
Member

alberto commented Jul 20, 2016

Why don't you ignore the whole dir?

@alberto
Copy link
Member

alberto commented Jul 20, 2016

Also, IMO this kind of things should be done as global ignores per user, instead of littering our .gitignorefile with every other editor config

@platinumazure
Copy link
Member

@alberto Which is worse? Having a .gitignore with a lot of editors' config files in it, or having those editor config files sneak into the repo?

@alberto
Copy link
Member

alberto commented Jul 20, 2016

@platinumazure that's a false dichotomy. We have a review process to prevent that

@nzakas
Copy link
Member

nzakas commented Jul 20, 2016

@platinumazure @alberto this line of discussion isn't helpful.

Up to this point, we've let people add their own .gitignore entries as necessary. I don't see that as a problem. The less we have to rely on the user doing to setup their dev environment, the better off we are.

@eslintbot
Copy link

LGTM

@mysticatea
Copy link
Member Author

I updated it to the whole directory.

@ilyavolodin
Copy link
Member

LGTM

@ilyavolodin ilyavolodin merged commit a0727f9 into master Jul 21, 2016
@mysticatea mysticatea deleted the chore/fix-gitignore branch July 30, 2016 08:36
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants