Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: no-use-before-define false negative on for-in/of (fixes #6699) #6719

Merged
merged 1 commit into from Jul 22, 2016

Conversation

mysticatea
Copy link
Member

@mysticatea mysticatea commented Jul 20, 2016

Fixes #6699.

This PR makes the rule handling ForInStatement.right and ForOfStatement.right as the initializer of variables.

@mention-bot
Copy link

@mysticatea, thanks for your PR! By analyzing the annotation information on this pull request, we identified @lencioni, @vitorbal and @ilyavolodin to be potential reviewers

@eslintbot
Copy link

LGTM

@nzakas
Copy link
Member

nzakas commented Jul 22, 2016

Lgtm. Marking as "update" because it is flagging something that previously was not flagged.

@nzakas nzakas merged commit 5320a6c into master Jul 22, 2016
@mysticatea mysticatea deleted the issue6699 branch July 30, 2016 06:26
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants