Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Clarify cache file deletion (fixes #4943) #6712

Merged
merged 1 commit into from Jul 23, 2016
Merged

Docs: Clarify cache file deletion (fixes #4943) #6712

merged 1 commit into from Jul 23, 2016

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 19, 2016

What issue does this pull request address?
#4943

What changes did you make? (Give an overview)

Added a warning that using --cache and then not using it will result in the cache file being deleted.

Is there anything you'd like reviewers to focus on?

Make sure the description is accurate.

@eslintbot
Copy link

LGTM

@mention-bot
Copy link

@nzakas, thanks for your PR! By analyzing the annotation information on this pull request, we identified @platinumazure, @evangoer and @gkz to be potential reviewers

@ilyavolodin
Copy link
Member

Sorry, it's not clear to me. What happens if you run eslint first with --cache and --cacheLocation, and then without --cache? Would the cache file get deleted?

@nzakas
Copy link
Member Author

nzakas commented Jul 20, 2016

If you run with --cache and --cache-location and then run without either flag, the cache file is not deleted (because we don't know where it is). If you run with just --cache-location without --cache, the cache file is deleted.

@nzakas
Copy link
Member Author

nzakas commented Jul 23, 2016

Merging for now, we can keep working on clarifying as necessary.

@nzakas nzakas merged commit 71ae64c into master Jul 23, 2016
@nzakas nzakas deleted the issue4943 branch July 23, 2016 15:28
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants