New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Correct a term in max-len.md (refs #6637) #6641
Conversation
@vsemozhetbyt, thanks for your PR! By analyzing the annotation information on this pull request, we identified @nzakas, @scriptdaemon and @iancmyers to be potential reviewers |
LGTM |
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
I've just signed the CLA, however I have not the git installed and I have not set any git config locally (I only used the web interface all the time). Does it mean I can't contribute to Eslint? |
@vsemozhetbyt You just need to set the "Name" and "E-mail" fields of your GitHub profile to match your CLA signature. That said, in your case, the jQuery foundation prefers you use a real name, and they have a heuristic that catches 1-word names which "require manual verification". So the best way to get this moving is to put in a first/last name on your Git profile and... see if you can amend the commit from GitHub somehow. (Worst case, you can edit the file on master again, after you've changed your profile name and e-mail as needed.) |
@platinumazure I've just change GitHub user name to three words and re-sign the CLA. Should I add another commit to this branch? Maybe to change "code units" to "16 bits code units"? |
I don't think that will work, because the CLA checker checks all commits in You can try searching the Github help docs for how to amend a commit after Please stop by in Gitter chat (https://gitter.im/eslint/eslint) if you need
|
LGTM |
@platinumazure I've just done all the command by portable configured git. It seems it does not help, unfortunately. |
LGTM |
Phew! It works with |
LGTM. Thanks! |
What issue does this pull request address?
#6637
What changes did you make? (Give an overview)
Replace "code points" by "code units" in the rule explanation.
Is there anything you'd like reviewers to focus on?
I guess not.