Fix: Warning behavior for executeOnText (fixes #6611) #6632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM, but waiting another day for others to look |
|
LGTM 👍 |
|
@gyandeeps remember to wait 2 days before merging, just to make sure everyone who wants to review has a chance to. Dont worry about this one, just keep in mind for the future. |
|
@nzakas this was pretty straight forward thats why i did it. |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request address?
#6611
What changes did you make? (Give an overview)
Previously,
executeOnText()would lint an ignored file ifwarnIgnoredwasfalse. I changed it so that it always ignores files that should be ignored and only outputs a warning whenwarnIgnoredistrue.Is there anything you'd like reviewers to focus on?
Nothing in particular.