Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove reference from 3.0.0 migration guide (refs #6605) #6618

Merged
merged 1 commit into from Jul 7, 2016

Conversation

platinumazure
Copy link
Member

What issue does this pull request address?

ESLint 3.0.0 migration guide, in section "Requiring Configuration to Run", mentions a useSpecificConfig option which is not part of the public API. The correct option is configFile (already mentioned).

What changes did you make? (Give an overview)

I removed the incorrect text. I also decided to augment the remaining text with info on how to pass in configuration files (or equivalent) via CLIEngine as well as CLI.

Is there anything you'd like reviewers to focus on?

Let me know if the extra text is too much.

NOTE: There is also an issue where baseConfig is not sufficient to suppress the No Config error message. This pull request intentionally does not address that problem. When I fix that issue (in a separate pull request), I will update the Migration Guide in the same commit to reflect that baseConfig is a valid method of including configuration.

@eslintbot
Copy link

LGTM

@platinumazure
Copy link
Member Author

I don't think the Travis failures are due to my code. I saw them on another PR. Either we have a general bug in ESLint triggering that error in Node 6 only (and said bug is already in master), or Travis is having some environmental trouble with its Node 6 CI VMs. Please correct me if I'm wrong and there is an issue with this (doc-only?) PR.

@nzakas
Copy link
Member

nzakas commented Jul 7, 2016

Lgtm.

@nzakas nzakas merged commit 10c3e91 into eslint:master Jul 7, 2016
@platinumazure platinumazure deleted the fix-migration-guide branch March 20, 2017 18:05
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants