Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Removed non-existing resource #6609

Merged
merged 1 commit into from Jul 6, 2016
Merged

Docs: Removed non-existing resource #6609

merged 1 commit into from Jul 6, 2016

Conversation

morkro
Copy link
Contributor

@morkro morkro commented Jul 6, 2016

Hello 馃憢,

I found out that the last resource of the semi rule documentation page doesn't exist anymore. I couldn't find any backup of it online either, so I think it's good to remove it from the documentation?

Since this is about the docs, and not eslint itself, I haven't filled out the issue template. Sorry if that was wrong.

@eslintbot
Copy link

Thanks for the pull request, @morkro! I took a look to make sure it's ready for merging and found some changes are needed:

  • The commit summary needs to begin with a tag (such as Fix: or Update:). Please check out our guide for how to properly format your commit summary and update it on this pull request.
  • Pull requests with code require an issue to be mentioned at the end of the commit summary, such as (fixes #1234). Please update the commit summary with an issue (file a new issue if one doesn't already exist).

Can you please update the pull request to address these?

(More information can be found in our pull request guide.)

@morkro morkro changed the title Removed non-existing resource Docs: Removed non-existing resource Jul 6, 2016
@ilyavolodin
Copy link
Member

LGTM. Thanks!

@ilyavolodin ilyavolodin merged commit 5010694 into eslint:master Jul 6, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants