Chore: add internal rule that validates meta property (fixes #6383) #6608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| @@ -12,3 +12,5 @@ versions.json | |||
| .eslintcache | |||
| .cache | |||
| /packages/**/node_modules | |||
| .vscode/setting.json | |||
| .sublimelinterrc | |||
There was a problem hiding this comment.
Are there any other editor lint settings that we should add?
There was a problem hiding this comment.
We just add them as we go, so I wouldn't worry about it right now.
I'm okay with the folder name, but what do you think about prefixing the rule with "eslint-" instead of "internal-"? |
|
@platinumazure I think |
| /** | ||
| * Gets the property of the Object node passed in that has the name specified. | ||
| * | ||
| * @param {String} property Name of the property to return. |
|
@vitorbal this looks great! Just a few small things to address. |
|
Thanks everyone for the great feedback! I will get to this later this weekend or sometime next week! |
|
LGTM |
|
LGTM |
|
Lgtm. Awesome work. |
|
Thanks everyone! 😄 |
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a custom rule to verify that all core rules have the correct
metaproperty format.As discussed in #6383 this is just an internal custom rule for now and not a plugin.
I modified the Makefile's lint task so it find our "internal rules" directory. Feedback welcome on a better folder name.