Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Make outerIIFEBody work correctly (fixes #6585) #6596

Merged
merged 1 commit into from Jul 5, 2016
Merged

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jul 4, 2016

This should make the outerIIFEBody option work as intended:

  1. Make sure the indent is a multiplier, not a set number of spaces.
  2. Fix false positive top-level IIFE detection.

@eslintbot
Copy link

LGTM

@ljharb
Copy link
Sponsor Contributor

ljharb commented Jul 4, 2016

This fixes the original problem I reported, thanks!

functionOffset = options.outerIIFEBody;
if (options.outerIIFEBody !== null && isOuterIIFE(calleeNode)) {
functionOffset = options.outerIIFEBody * indentSize;
console.log(functionOffset);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sneaked in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh! Thanks.

@eslintbot
Copy link

LGTM

@nzakas nzakas merged commit a2cfa1b into master Jul 5, 2016
@nzakas nzakas deleted the issue6585 branch July 5, 2016 17:25
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants