Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Pull request template #6568

Merged
merged 1 commit into from Jul 5, 2016
Merged

Docs: Pull request template #6568

merged 1 commit into from Jul 5, 2016

Conversation

nzakas
Copy link
Member

@nzakas nzakas commented Jun 30, 2016

We've had quite a few pull requests opened recently without issues, so I'd like to see if adding a pull request template will help minimize that. This PR adds a simple template with just a few questions.

@eslintbot
Copy link

LGTM

**What changes did you make? (Give an overview)**


**Is there anything you'd like to reviewers to focus on?**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/like to reviewers/like reviewers (or like for reviewers)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not only we require an issue, but it must also be accepted first. We don't want people to open an issue and submit a PR immediately.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alberto how would you suggest updating what I have here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specifically, all pull requests containing code require an accepted issue (documentation-only pull requests do not require an issue). If this pull requests contain code, and there isn't yet an issue explaining why you're submitting this pull request, please stop and open a new issue first. If the issue is not accepted yet, please wait.

@platinumazure
Copy link
Member

Small typo, otherwise LGTM

@eslintbot
Copy link

LGTM

@nzakas
Copy link
Member Author

nzakas commented Jun 30, 2016

Updated.

@alberto
Copy link
Member

alberto commented Jun 30, 2016

Sorry, I missed this the first time:

"contains code"

@scriptdaemon
Copy link
Contributor

If this pull requests -> If this pull request

You can also remove the immediately following comma, as it is not a list of three or more items nor is it separating more than one independent clause.

@eslintbot
Copy link

LGTM

@nzakas
Copy link
Member Author

nzakas commented Jul 1, 2016

Thanks all, fixed.

@nzakas nzakas merged commit 124d8a3 into master Jul 5, 2016
@nzakas nzakas deleted the prnote branch July 5, 2016 17:39
pmcelhaney added a commit to pmcelhaney/eslint that referenced this pull request Jul 5, 2016
pmcelhaney added a commit to pmcelhaney/eslint that referenced this pull request Jul 5, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants