New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Pull request template #6568
Conversation
LGTM |
**What changes did you make? (Give an overview)** | ||
|
||
|
||
**Is there anything you'd like to reviewers to focus on?** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/like to reviewers/like reviewers (or like for reviewers)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not only we require an issue, but it must also be accepted first. We don't want people to open an issue and submit a PR immediately.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alberto how would you suggest updating what I have here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Specifically, all pull requests containing code require an accepted issue (documentation-only pull requests do not require an issue). If this pull requests contain code, and there isn't yet an issue explaining why you're submitting this pull request, please stop and open a new issue first. If the issue is not accepted yet, please wait.
Small typo, otherwise LGTM |
LGTM |
Updated. |
Sorry, I missed this the first time: "contains code" |
If this pull requests -> If this pull request You can also remove the immediately following comma, as it is not a list of three or more items nor is it separating more than one independent clause. |
LGTM |
Thanks all, fixed. |
We've had quite a few pull requests opened recently without issues, so I'd like to see if adding a pull request template will help minimize that. This PR adds a simple template with just a few questions.