Chore: Remove TDZ scope type condition from no-unused-vars #12055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eslint-deprecated
bot
added
the
triage
aladdin-add
added
accepted
|
it was removed in eslint-scope@4.0.0-alpha.0 FYI: https://github.com/eslint/eslint-scope/releases/tag/v4.0.0-alpha.0 LGTM, but I would like to have one more review. :) |
ilyavolodin
approved these changes
Aug 12, 2019
fetus-hina
added a commit
to fetus-hina/stat.ink
that referenced
this pull request
Aug 21, 2019
fetus-hina
added a commit
to fetus-hina/stat.ink
that referenced
this pull request
Aug 21, 2019
fetus-hina
added a commit
to fetus-hina/stat.ink
that referenced
this pull request
Aug 21, 2019
This was referenced Aug 27, 2019
This was referenced Sep 12, 2019
This was referenced Nov 9, 2019
eslint-deprecated
bot
added
the
archived due to age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[X] Other, please explain:
To remove a condition that is always
trueas the TDZ scope type does not exist anymore.What changes did you make? (Give an overview)
Removed
scope.type !== "TDZ"fromno-unused-varsIs there anything you'd like reviewers to focus on?