Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: do not recommend global-installed usage #12016

Merged
merged 1 commit into from Aug 12, 2019

Conversation

aladdin-add
Copy link
Member

What is the purpose of this pull request? (put an "X" next to item)

[x] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[ ] Other, please explain:

What changes did you make? (Give an overview)
do not recommend global-installed usage. this has been discussed for a long time, and seems we have done some work in this direction.

refs:

Is there anything you'd like reviewers to focus on?
seems it was not a trivial change, will it discussed in a TSC meeting?

@aladdin-add aladdin-add added documentation Relates to ESLint's documentation evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Jul 24, 2019
@ilyavolodin
Copy link
Member

I think it's fine to include those changes. Don't think they are controversial enough to warren TSC discussion.

@kaicataldo kaicataldo marked this pull request as ready for review July 24, 2019 13:48
Copy link
Member

@kaicataldo kaicataldo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops - sorry, I didn't realize clicking that button would remove the draft status!

LGTM, thanks for contributing!

@aladdin-add
Copy link
Member Author

@kaicataldo no worries, leaving it as a draft, I just want to double-check if some more background is required. but it seems pretty clear. 😄

@aladdin-add
Copy link
Member Author

well, I'm going to leave it open for a longer time -- to see if there is any objections from the team, and the community.

@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 6, 2019
@aladdin-add aladdin-add merged commit 11be2f8 into eslint:master Aug 12, 2019
@GrayedFox
Copy link
Contributor

To be honest, I've always wondered why a global installation was recommended, when nearly every project I've ever worked on bundles a specific version of eslint within the package.json 😸

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants