Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: update docs for object-curly-spacing (fixes #11634) #12009

Merged
merged 1 commit into from Jul 21, 2019
Merged

Docs: update docs for object-curly-spacing (fixes #11634) #12009

merged 1 commit into from Jul 21, 2019

Conversation

golopot
Copy link
Contributor

@golopot golopot commented Jul 20, 2019

What is the purpose of this pull request? (put an "X" next to item)

[ ] X Documentation update

fixes #11634

@eslint-deprecated eslint-deprecated bot added the triage An ESLint team member will look at this issue soon label Jul 20, 2019
@aladdin-add aladdin-add added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation and removed triage An ESLint team member will look at this issue soon labels Jul 20, 2019
aladdin-add
aladdin-add approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@aladdin-add aladdin-add left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

platinumazure
platinumazure approved these changes Jul 20, 2019
View reviewed changes
Copy link
Member

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@platinumazure platinumazure merged commit 105c098 into eslint:master Jul 21, 2019
@platinumazure
Copy link
Member

Thanks for contributing!

This was referenced Aug 27, 2019
Merged
Closed
Merged
Merged
@golopot golopot deleted the patch-2 branch September 7, 2019 18:29
This was referenced Sep 12, 2019
Merged
Merged
Merged
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2019
Open
This was referenced Nov 9, 2019
Open
Open
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Jan 18, 2020
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Jan 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@aladdin-add aladdin-add aladdin-add approved these changes

Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs: Clarify option "multiline" for object-curly-newline
3 participants
@golopot @platinumazure @aladdin-add