New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chore: update release script for new website repo #12006
Conversation
577d8bf
to
bfd6eee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.
Do we want to maybe use a name like "eslint-website"? It could be a pain if someone has their own "website" repo in their GitHub project directory. It's not a problem for me, at least.
That’s an interesting point. Do you mean to rename the repository or just the name of the directory when we clone it in the release script? My inclination is that it’s probably fine as is since the releases are mostly run in Jenkins, but I don’t have a strong opinion and am happy to change it if others are concerned! |
I think that we should move the script to |
@mysticatea That sounds good to me. How do you feel about landing this first (just to make sure we’re not blocking the upcoming release)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
As a side benefit, if we run the eslint release first and then run the site generation afterwards, we can also bundle eslint and espree in |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[ ] Bug fix (template)
[ ] New rule (template)
[ ] Changes an existing rule (template)
[ ] Add autofixing to a rule
[ ] Add a CLI option
[ ] Add something to the core
[x] Other, please explain: Update release script
What changes did you make? (Give an overview)
refs eslint/archive-website#576
This updates the release script now that we've change the website repository name to
eslint/website
.Is there anything you'd like reviewers to focus on?
I've already changed the repository name, turned off publishing to GitHub Pages, and have updated the Jenkins script. Did I miss anything?