New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update: support bigint and dynamic import (refs #11803) #11983
Conversation
We can update |
What's the status of this PR? #11803 depends on it. |
Please track #11803. This PR is waiting on new |
A small fix for
There might be an issue with |
7240156
to
85a73d9
Compare
This avoids a dependency deduplication conflict for developers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @mysticatea and @platinumazure for working on this!
What is the purpose of this pull request? (put an "X" next to item)
[X] Add something to the core (#11803).
What changes did you make? (Give an overview)
This PR adds supports of bigint and dynamic import.
espree
andeslint-visitor-keys
.CodePathAnalyzer
to handleImportExpression
node as throwable.new-cap
rule's false positive.astUtils.getPrecedence
function to fixno-extra-paren
false positive.astUtils.isNullLiteral
function to fixeqeqeq
false positive.func-call-spacing
rule to recognizeImportExpression
node.function-paren-newline
rule to recognizeImportExpression
node.indent
rule to recognizeImportExpression
node.no-extra-parens
rule to recognizeImportExpression
node.env.es2020
to declare new global variables:BigInt
,BigInt64Array
, andBigUint64Array
.env.es2017
to declare new global variables:Atomics
andSharedBufferArray
. I'm not sure why we have not had it.(platinumazure: Consumed espree/eslint-visitor-keys, fixed merge conflicts, did some minor chores to get tests to pass-- see commit list.)
Is there anything you'd like reviewers to focus on?
There are a ton of remaining stuff (see #11803), but those are "enhancements which increase errors." As following our semver policy, we need a major update to add those... :(
Or maybe can we add those with a minor?