no-extra-parens handles some MemberExpressions incorrectly

[not-an-aardvark]

Tell us about your environment

• ESLint Version: master
• Node Version: 8.4.0
• npm Version: 5.3.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

Configuration

rules:
  no-extra-parens: error

What did you do? Please include the actual source code causing the issue.

(foo()).bar;

new (foo.bar().Baz);

What did you expect to happen?

I expected an error to be reported on line 1, and no error on line 3.

What actually happened? Please include the actual, raw output from ESLint.

An error was reported on line 3, but no error was reported on line 1.

edit: added a false positive case

[jackyho112]

May I give this a go? Will start working on this right away.

[not-an-aardvark]

Sure, feel free. Thanks for contributing!

[jackyho112]

@not-an-aardvark

I have been familiarizing myself with the library and investigating the issue. I think I have a few ideas on how to fix them. I do want to confirm the logics with you though.

The first line should have a warning because parens around a call expression are unnecessary?

The third line should not have a warning because parens are necessary around a member expression within a new expression?

[platinumazure]

I think extra parens around a new expression should only be allowed if there are intervening parentheses.

new (Foo.Bar.Baz);  // unnecessary parens
new (Foo.Bar().Baz);  // necessary parens

[jackyho112]

I will look into it more to find the necessary or unnecessary aspects of these parens.