Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix example for the MemberExpression option on the indent rule #9056

Closed
royerboat opened this issue Aug 1, 2017 · 2 comments
Closed

Fix example for the MemberExpression option on the indent rule #9056

royerboat opened this issue Aug 1, 2017 · 2 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules

Comments

@royerboat
Copy link
Contributor

Tell us about your environment

  • ESLint Version: 4.1.1
  • Node Version: 6.9.4
  • npm Version: 3.10.10

What parser (default, Babel-ESLint, etc.) are you using?

default

What did you do? Please include the actual source code causing the issue.

The docs have the following example for the MemberExpression option of the indent rule.

/*eslint indent: ["error", 2, { "MemberExpression": 1 }]*/

foo
  .bar
  .baz();

// Any indentation is permitted in variable declarations and assignments.
var bip = aardvark.badger
                  .coyote;

However, it looks like the comment about indentation being permitted in variable declarations and assignments was removed in the following commit, but the example was not updated: 0c2a386

What did you expect to happen?

The example should remove the comment about indentation being permitted in variable declarations and assignments since this is no longer true.

What actually happened? Please include the actual, raw output from ESLint.

N/A

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Aug 1, 2017
@platinumazure platinumazure added accepted There is consensus among the team that this change meets the criteria for inclusion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Aug 1, 2017
@platinumazure
Copy link
Member

Hi @royerboat, thanks for the issue. You are absolutely right that this needs to be fixed.

Would you like to submit a pull request?

@royerboat
Copy link
Contributor Author

Sure, I'd be happy to.

@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

3 participants