Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off branch builds for Travis and AppVeyor #8804

Closed
ilyavolodin opened this issue Jun 26, 2017 · 7 comments · Fixed by homezen/eslint-config-homezen#43
Closed

Turn off branch builds for Travis and AppVeyor #8804

ilyavolodin opened this issue Jun 26, 2017 · 7 comments · Fixed by homezen/eslint-config-homezen#43
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features infrastructure Relates to the tools used in the ESLint development process

Comments

@ilyavolodin
Copy link
Member

ilyavolodin commented Jun 26, 2017

Currently any PR made by core member of ESLint team is built 10 times on Travis. 5 as PR and 5 as branch. I think we can safely turn off branch builds in both Travis and AppVeyor and lower the load we put on those services (also it's sometimes takes longer for both branch and PR builds to complete).

@ilyavolodin ilyavolodin added core Relates to ESLint's core APIs and features evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion infrastructure Relates to the tools used in the ESLint development process tsc agenda This issue will be discussed by ESLint's TSC at the next meeting labels Jun 26, 2017
@platinumazure
Copy link
Member

👍 especially if team members can do branch builds on demand.

@not-an-aardvark
Copy link
Member

@platinumazure I'm not sure that would be possible. Could you elaborate on why you would find this useful? (It seems like it would be easier to just run npm test locally, but there might be a component that I'm missing.)

@platinumazure
Copy link
Member

platinumazure commented Jun 26, 2017 via email

@ilyavolodin
Copy link
Member Author

One additional extra. I noticed that our CI builds are for some reason building jsDoc documentation after each build. Not really sure why that's necessary. We should remove it to speed builds up.

@platinumazure
Copy link
Member

@eslint/eslint-team Any thoughts on this issue?

@gyandeeps
Copy link
Member

I think we have majority vote for this. Do we still need to discuss this in TSC meeting?

@alberto alberto added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion tsc agenda This issue will be discussed by ESLint's TSC at the next meeting labels Jul 4, 2017
@alberto
Copy link
Member

alberto commented Jul 4, 2017

I don't think so. Marking as accepted.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion core Relates to ESLint's core APIs and features infrastructure Relates to the tools used in the ESLint development process
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants