New Rule: Enforce return in getter

[jaredmcateer]

Please describe what the rule should do:

Enforces that a return statement is present in property getters

What category of rule is this? (place an "X" next to just one item)

[ ] Enforces code style
[X] Warns about a potential error
[ ] Suggests an alternate way of doing something
[ ] Other (please specify:)

Provide 2-3 code examples that this rule will warn about:

/*eslint getter-return: "error"*/

// Incorrect
class MyClass {
  get a() {
     this.retreiveVal('a');
  }
}

function MyConstructorFunction() {
  Object.defineProperty(this, 'a', {
    get: function () {
      this.retreiveVal('a');
    }
  });
}


// Correct
class MyClass {
  get a() {
     return this.retreiveVal('a');
  }
}

function MyConstructorFunction() {
  Object.defineProperty(this, 'a', {
    get: function () {
       return this.retreiveVal('a');
    }
  });
}

Why should this rule be included in ESLint (instead of a plugin)?

I cannot think of a valid use case why someone would want to define a getter that did not return a value and it can be easily overlooked when reviewing a long list of getter/setters. I think the problem is generic enough that it should be included by ESLint.

[platinumazure]

I'm 👍 to this idea. I think we should for sure do this in getter methods. I'm less sure about Object.defineProperty and friends just due to static analysis limitations, but I'm not opposed to adding it there either.

[platinumazure]

@jaredmcateer Would you be interested in writing a PR if this gets accepted?

[jaredmcateer]

I am travelling for a few weeks but I would definitely be up for writing this rule when I am back and have the time.

…

On Apr 19, 2017 4:55 AM, "Kevin Partington" ***@***.***> wrote: @jaredmcateer <https://github.com/jaredmcateer> Would you be interested in writing a PR if this gets accepted? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#8449 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAvs5Atdbwv_UN9ehXXTD7ceIqdSOZfqks5rxSNEgaJpZM4M6rss> .

[ilyavolodin]

Looks like we have enough votes to accept this. Just need a champion. Anyone willing to champion this issue?

[platinumazure]

I'll champion.

@jaredmcateer Let us know when you get a chance to start work on this, or if your schedule fills up and it looks like you won't be able to do it. No rush, and enjoy your travels!

[aladdin-add]

working on this. maybe the following weekend.