Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-var incorrectly autofixes declarations in statement position #7961

Closed
not-an-aardvark opened this issue Jan 21, 2017 · 0 comments · Fixed by singapore/lint-condo#218, renovatebot/renovate#64 or SimpliField/sf-preferences#26 · May be fixed by iamhunter/teammates#4
Closed

no-var incorrectly autofixes declarations in statement position #7961

not-an-aardvark opened this issue Jan 21, 2017 · 0 comments · Fixed by singapore/lint-condo#218, renovatebot/renovate#64 or SimpliField/sf-preferences#26 · May be fixed by iamhunter/teammates#4
Assignees
@not-an-aardvark
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@not-an-aardvark
Copy link
Member

Tell us about your environment

  • ESLint Version: master
  • Node Version: 7.4.0
  • npm Version: 4.0.5

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

none

What did you do? Please include the actual source code causing the issue.

/* eslint no-var: error */

if (foo) var bar = 1;

What did you expect to happen?

I expected an error to be reported, but no fix to be performed.

What actually happened? Please include the actual, raw output from ESLint.

The code was fixed to

if (foo) let bar = 1;

which is a syntax error.
@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules labels Jan 21, 2017
@not-an-aardvark not-an-aardvark self-assigned this Jan 21, 2017
not-an-aardvark added a commit that referenced this issue Jan 21, 2017
@not-an-aardvark
Fix: no-var autofix syntax error in single-line statements (fixes #7961)
99666e2
@not-an-aardvark not-an-aardvark mentioned this issue Jan 21, 2017
Merged
This was referenced Jan 25, 2017
Merged
Merged
@SebastienElet SebastienElet mentioned this issue Jan 31, 2017
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@not-an-aardvark not-an-aardvark

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
1 participant
@not-an-aardvark