Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using "first" for indent can result in message about "NaN spaces" with nested arrays #7727

Closed
Trott opened this issue Dec 9, 2016 · 1 comment
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@Trott
Copy link
Contributor

Trott commented Dec 9, 2016

Tell us about your environment

  • ESLint Version: current master
  • Node Version: 7.2.1
  • npm Version: 3.10.10

What parser (default, Babel-ESLint, etc.) are you using?
default

Please show your full configuration:
config file is empty

What did you do? Please include the actual source code causing the issue.

Running command:

eslint --rule 'indent: [2, 2, {ArrayExpression: first}]' test.js

with contents of test.js as follows:

var foo = [
  [
     1, 2, 3,
     4, 5, 6
  ]
];

What did you expect to happen?

Either no error or else expected indentation of some positive integer.

What actually happened? Please include the actual, raw output from ESLint.

2:3 error Expected indentation of NaN spaces but found 2 indent
5:3 error Expected indentation of NaN spaces but found 2 indent

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Dec 9, 2016
@Trott
Copy link
Contributor Author

Trott commented Dec 9, 2016

@not-an-aardvark I imagine there may be a release planned for tomorrow. If so, I imagine you'll want to fix this issue (or revert the new feature) before releasing.

@not-an-aardvark not-an-aardvark added accepted There is consensus among the team that this change meets the criteria for inclusion bug ESLint is working incorrectly rule Relates to ESLint's core rules and removed triage An ESLint team member will look at this issue soon labels Dec 9, 2016
@not-an-aardvark not-an-aardvark self-assigned this Dec 9, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

3 participants