Rule proposal: Template tag spacing

[phaux]

Please describe what the rule should do: Similar to func-call-spacing – it would enforce spacing between template tag and template literal.

What category of rule is this? (place an "X" next to just one item)

• Enforces code style
• Warns about a potential error
• Suggests an alternate way of doing something
• Other (please specify:)

Provide 2-3 code examples that this rule will warn about:

// correct with spacing required
const [user] = await sql `SELECT * FROM users WHERE id = ${id}`
ctx.body = {
  name: user.name,
  avatar: escape `/avatars/${user.id}.jpg`,
}

// correct with spacing disallowed
const [user] = await sql`SELECT * FROM users WHERE id = ${id}`
ctx.body = {
  name: user.name,
  avatar: escape`/avatars/${user.id}.jpg`,
}

[platinumazure]

Seems reasonable to me-- I'll 👍 this.

[vitorbal]

I'll 👍 this too. I think we should allow configuring "always" or "never"
having spacing btwn them.
On Mon, Nov 21, 2016 at 7:52 PM Kevin Partington notifications@github.com
wrote:

Seems reasonable to me-- I'll 👍 this.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#7631 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAmNdgktmJGu9O8J0vzm6CHJfXFPsTvqks5rAehdgaJpZM4K4gqN
.

[dead-claudia]

👍 from me, too. And I agree @vitorbal (although one space should also be an option).

[vitorbal]

@phaux are you willing to work on a PR for this if it gets accepted?

[phaux]

@vitorbal I think I can do it

[ilyavolodin]

Anyone on the team wants to champion this? It looks like there are more then enough votes to accept this, just need a champion.

[kaicataldo]

I'll champion this. @phaux Is everything clear? Please let us know if you need any help with anything, either here in this issue or in our Gitter.

[vitorbal]

marking this as accepted as we have a champion and enough +1's

[jwilsson]

I'd like to take a stab at this if no one else is working on it, @phaux?

[kaicataldo]

@jwilsson Go for it! It looks like we didn't discuss a configuration schema, but it seems to me like this should have one string option that is either "always" or "never" (similar to template-curly-spacing). Thoughts on what the default should be @eslint/eslint-team?

Aside from needing to figure out the default value, is everything else clear? Please feel free to comment on here or swing by the ESLint Gitter if you need any help!

[not-an-aardvark]

"always" and "never" sound good to me.

I think the default should be "never", since I've never seen anyone intentionally use a space here.

[vitorbal]

Agreed on "never" by default

…

On Wed, Jan 11, 2017 at 4:38 PM, Teddy Katz ***@***.***> wrote: "always" and "never" sound good to me. I think the default should be "never", since I've never seen anyone intentionally use a space here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7631 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAmNdrdFXn-wDYe2kCyEUNX0t-9Wl1c-ks5rRPd8gaJpZM4K4gqN> .

[kaicataldo]

Agreed 👍

[jwilsson]

Cool, I'll take a look in the coming days.

[phaux]

I haven't began working on it yet so go ahead @jwilsson .

I agree upon the default, because it makes this new syntax stand out more. Putting a space there makes it look less like an invocation (even tho I think it looks prettier)