Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release on September 23, 2016 #7038

Closed
nzakas opened this issue Sep 1, 2016 · 4 comments
Closed

Release on September 23, 2016 #7038

nzakas opened this issue Sep 1, 2016 · 4 comments
Assignees
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion infrastructure Relates to the tools used in the ESLint development process

Comments

@nzakas
Copy link
Member

nzakas commented Sep 1, 2016

The scheduled release on Friday, September 23, 2016 is assigned to:

This issue should be closed when the release has been completed.

@nzakas nzakas added infrastructure Relates to the tools used in the ESLint development process accepted There is consensus among the team that this change meets the criteria for inclusion labels Sep 1, 2016
@ilyavolodin
Copy link
Member

Release went smoothly overall. After minor release on Friday, we found an issue with Espree and did a follow-up patch release on Monday to upgrade Espree version. There are still 2 outstanding regressions from the Friday build that were reported, but still do not have a fix available. Right now, the main problem is not knowing if we should do another follow-up patch release after those issues are fixed, or if we should wait for normal release in 2 weeks.

@gyandeeps
Copy link
Member

gyandeeps commented Sep 27, 2016

I think the release was very smooth and easy. Thanks for automating all this @nzakas .

@nzakas nzakas added the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Sep 28, 2016
@nzakas
Copy link
Member Author

nzakas commented Sep 28, 2016

While the initial release seems to have gone smoothly, I think the aftermath has been a bit messy. What I've picked up from the chat:

  1. People were unsure if there was going to be a patch release on Monday.
  2. There was a lot of confusion over whether or not there should be a second patch release. That confusion continued into Wednesday, at which point at least one semver-minor PR had been merged, which meant we couldn't do a second patch release and instead would have to either do another non-patch release or wait until the next regularly scheduled release.

I think we should do a post-mortem on this release during the TSC meeting to find out what happened and what we can do better to manage the Monday/Tuesday after regular releases.

@kaicataldo
Copy link
Member

As per the discussion in today's TSC meeting, we now have a regression label and the following issue to hammer out guidelines for patch releases: #7277

@kaicataldo kaicataldo removed the tsc agenda This issue will be discussed by ESLint's TSC at the next meeting label Sep 29, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion infrastructure Relates to the tools used in the ESLint development process
Projects
None yet
Development

No branches or pull requests

4 participants