Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use eslint-config-airbnb-base for project initialization #6986

Closed
alberto opened this issue Aug 26, 2016 · 5 comments
Closed

Use eslint-config-airbnb-base for project initialization #6986

alberto opened this issue Aug 26, 2016 · 5 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint

Comments

@alberto
Copy link
Member

alberto commented Aug 26, 2016

When running eslint --init one of the options is to use airbnb style as a base. If chosen, we install eslint-config-airbnb which requires eslint-plugin-react among others.

I think we should install eslint-config-airbnb-base instead.
@alberto alberto added enhancement This change enhances an existing feature of ESLint cli Relates to ESLint's command-line interface evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 26, 2016
@platinumazure
Copy link
Member

Seems reasonable to me. I think @ljharb made a similar recommendation in the JSCS migration doc issue.

@ljharb
Copy link
Sponsor Contributor

ljharb commented Aug 27, 2016

Yes, please do this - that much more closely will match developer expectations.

Please note, the command in step 1 here should be used, instead of hardcoding anything, to dynamically install the correct peer dependencies at the right versions.

@nzakas nzakas added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Sep 1, 2016
@nzakas
Copy link
Member

nzakas commented Sep 1, 2016

Yeah, let's make that change.

@gyandeeps
Copy link
Member

@jacobp100 I think you have done the work, do you want to open a PR of it?

@jacobp100
Copy link

I'll try and make time for it—I'll need to redo the work, but it's not a huge amount

alberto added a commit that referenced this issue Dec 5, 2016
@alberto
Update: Add airbnb-base to init styleguides (fixes #6986)
4adfef1
@alberto alberto mentioned this issue Dec 5, 2016
Merged
alberto added a commit that referenced this issue Dec 5, 2016
@alberto
Update: Add airbnb-base to init styleguides (fixes #6986)
e5a9a12
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion cli Relates to ESLint's command-line interface enhancement This change enhances an existing feature of ESLint
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@nzakas @ljharb @alberto @platinumazure @gyandeeps @jacobp100