Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

npm test does infinite looping #6870

Closed
mysticatea opened this issue Aug 9, 2016 · 6 comments
Closed

npm test does infinite looping #6870

mysticatea opened this issue Aug 9, 2016 · 6 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly build This change relates to ESLint's build process

Comments

@mysticatea
Copy link
Member

Currently, the test of ESLint seems to be broken on Windows.

https://ci.appveyor.com/project/nzakas/eslint/build/3834

It seems to start infinite looping (it's consuming CPU 1 Core 100%) after it printed "Validating JavaScript files".
This has reproduced on my local machine.

I'm not sure what is happening...
@mysticatea mysticatea added bug ESLint is working incorrectly build This change relates to ESLint's build process evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 9, 2016
@mysticatea
Copy link
Member Author

  • Windows 7
  • both PowerShell (GitHub Shell) and cmd.exe
  • both Node 4.4.7 and Node 6.3.1
  • npm 3.9.0

@ilyavolodin ilyavolodin added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 9, 2016
@ilyavolodin
Copy link
Member

I can confirm. It's also goes into infinite loop on my machine. Could this be related somehow to #6850 that's the only thing that changed recently. But then I'm not really sure why it's failing on Windows only.

@gyandeeps
Copy link
Member

Confirmed: If I remove this commit f8ab8f1 then the lint works fine. This is currently the top most commit.

@gyandeeps
Copy link
Member

Found the issue. Will send a PR with the fix.
Reason is that we hitting the limit on how many files can be passed though cli into eslint. Will explain more once i have the PR out.

gyandeeps added a commit that referenced this issue Aug 9, 2016
@gyandeeps
Chore: Fix glob for core js files for lint (fixes #6870)
29a65cf
@gyandeeps
Copy link
Member

Fun facts:

  • I did this console.log(process.argv.join("").length)
  • I could make the console work for 7860
  • as soon as i add one more character, it would hangup

@gyandeeps gyandeeps mentioned this issue Aug 9, 2016
Merged
@mysticatea
Copy link
Member Author

@gyandeeps Cool. Thank you so much!

This was referenced Aug 11, 2016
Merged
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly build This change relates to ESLint's build process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ilyavolodin @mysticatea @gyandeeps