Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type error in an internal-rule #6848

Closed
mysticatea opened this issue Aug 5, 2016 · 2 comments
Closed

Type error in an internal-rule #6848

mysticatea opened this issue Aug 5, 2016 · 2 comments
Assignees
@vitorbal
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules

Comments

@mysticatea
Copy link
Member

I just found that our a CI build was failed by TypeError of internal-no-invalid-meta rule.
I have not investigated it yet.

https://travis-ci.org/eslint/eslint/jobs/149564000#L559
@mysticatea mysticatea added bug ESLint is working incorrectly rule Relates to ESLint's core rules accepted There is consensus among the team that this change meets the criteria for inclusion labels Aug 5, 2016
@vitorbal
Copy link
Member

vitorbal commented Aug 5, 2016

@mysticatea i'll investigate. Looks like the rule does not follow the new rule format and does not provide a meta property.

@vitorbal vitorbal self-assigned this Aug 5, 2016
@vitorbal
Copy link
Member

vitorbal commented Aug 5, 2016

Thanks for opening the issue, @mysticatea! I notified the author of the PR that he needs to update his rule to the new format.

But I'm also going to work on a better handling of the case where a rule is on old format, so it shows a lint message instead of throwing!

vitorbal added a commit to vitorbal/eslint that referenced this issue Aug 5, 2016
@vitorbal
Fix: dont throw if rule is in old format (fixes eslint#6848)
28f3a38
@vitorbal vitorbal mentioned this issue Aug 5, 2016
Merged
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vitorbal vitorbal

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vitorbal @mysticatea