New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nested dependency circular-json is failing our license check #6816
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
infrastructure
Relates to the tools used in the ESLint development process
Comments
nzakas
added
bug
ESLint is working incorrectly
infrastructure
Relates to the tools used in the ESLint development process
accepted
There is consensus among the team that this change meets the criteria for inclusion
labels
Aug 1, 2016
Looks like it's a transitive dependency:
CC: @royriojas |
nzakas
added a commit
that referenced
this issue
Aug 1, 2016
nzakas
added a commit
that referenced
this issue
Aug 1, 2016
nzakas
added a commit
that referenced
this issue
Aug 1, 2016
alberto
added a commit
that referenced
this issue
Aug 1, 2016
nzakas
pushed a commit
that referenced
this issue
Aug 1, 2016
Just for record on this issue: circular-json has accepted my PR to add a license to their package.json, so hopefully we can proceed without having pinned dependencies in the future. |
alberto
added a commit
that referenced
this issue
Aug 1, 2016
eslint-deprecated
bot
added
the
archived due to age
This issue has been archived; please open a new issue for any further discussion
label
Feb 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
accepted
There is consensus among the team that this change meets the criteria for inclusion
archived due to age
This issue has been archived; please open a new issue for any further discussion
bug
ESLint is working incorrectly
infrastructure
Relates to the tools used in the ESLint development process
For the master branch, Travis checks are now failing because the license checker is saying that
circular-json
doesn't have a correct license. It's likely that one of our dependencies just started including it. We need to figure out which one and probably just set a stricter version to work around this.Longer-term, we can probably send a pull request to
circular-json
to get the license information put intopackage.json
.The text was updated successfully, but these errors were encountered: