Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MemberExpression option is currently breaking builds, needs to be made opt-in #6797

Closed
Trott opened this issue Jul 29, 2016 · 4 comments
Closed
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon

Comments

@Trott
Copy link
Contributor

Trott commented Jul 29, 2016

What version of ESLint are you using?

3.2.0

What parser (default, Babel-ESLint, etc.) are you using?

n/a

Please show your full configuration:

n/a

What did you do? Please include the actual source code causing the issue.

Code like this used to pass:

foo
  .bar
.baz;

Now it throws an error because the new MemberExpression option of indent is not opt-in

What did you expect to happen?

Code that wasn't broken would remain unbroken

What actually happened? Please include the actual, raw output from ESLint.

@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Jul 29, 2016
Trott added a commit to Trott/eslint that referenced this issue Jul 29, 2016
The `MemberExpression` option should be opt-in as it is a breaking
change.
@markelog
Copy link
Member

Is that a duplicate of #6795?

@Trott
Copy link
Contributor Author

Trott commented Jul 29, 2016

Fix for 6795 is "ignore assignment statements". Fix for 6797 is "make it
opt in". These are not mutually exclusive fixes. I recommend doing both.
On Fri, Jul 29, 2016 at 3:56 PM Oleg Gaidarenko notifications@github.com
wrote:

Is that a duplicate of #6795
#6795?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#6797 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAr4M_iUq3w-vETdHv31ZyA5AcVrbPfpks5qaoUAgaJpZM4JYmJu
.

@markelog
Copy link
Member

But both PRs are sent to fix one "breaking change"... but okay, I understand the logic behind it

(let's not discuss this in two places :)

@nzakas nzakas changed the title MemberExpression option is currently a breaking change, needs to be made opt-in MemberExpression option is currently breaking builds, needs to be made opt-in Jul 30, 2016
@nzakas
Copy link
Member

nzakas commented Jul 30, 2016

Let's just use #6795 to discuss the overall problem, this issue isn't really separate.

@nzakas nzakas closed this as completed Jul 30, 2016
Trott added a commit to Trott/eslint that referenced this issue Jul 30, 2016
The `MemberExpression` option should be opt-in as it is a breaking
change.
gyandeeps pushed a commit that referenced this issue Aug 1, 2016
The `MemberExpression` option should be opt-in as it is a breaking
change.
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
archived due to age This issue has been archived; please open a new issue for any further discussion triage An ESLint team member will look at this issue soon
Projects
None yet
Development

No branches or pull requests

4 participants