Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make max-lines report the actual number of lines #6766

Closed
jrencz opened this issue Jul 26, 2016 · 5 comments
Closed

Make max-lines report the actual number of lines #6766

jrencz opened this issue Jul 26, 2016 · 5 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules

Comments

@jrencz
Copy link
Contributor

jrencz commented Jul 26, 2016

What version of ESLint are you using?
3.1.1

What parser (default, Babel-ESLint, etc.) are you using?
default

Please show your full configuration:
n/a

What did you do? Please include the actual source code causing the issue.
I enabled the max-lines rule

What did you expect to happen?
Rule should tell me how many lines each too long file has

What actually happened? Please include the actual, raw output from ESLint.
Rule only told me that the file is too long and what was the max allowed number of lines
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Jul 26, 2016
jrencz added a commit to jrencz/eslint that referenced this issue Jul 26, 2016
@jrencz
Update: make max-lines report the actual number of lines (fixes esl…
b90606a 
…int#6766)

Instead of reporting only that `max` value has been exceeded
it now also reports how many lines there is in the file.
@platinumazure platinumazure added enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jul 27, 2016
@platinumazure
Copy link
Member

Seems reasonable to me. 👍

@mysticatea
Copy link
Member

mysticatea commented Jul 27, 2016 •
edited

I think helpful that the rule warns those violated lines rather than the top of files?

Ops, sorry, never mind.

@vitorbal vitorbal mentioned this issue Jul 28, 2016
Merged
jrencz added a commit to jrencz/eslint that referenced this issue Aug 4, 2016
@jrencz
Update: make max-lines report the actual number of lines (fixes esl…
807b20d 
…int#6766)

Instead of reporting only that `max` value has been exceeded
it now also reports how many lines there is in the file.
@vitorbal
Copy link
Member

vitorbal commented Aug 4, 2016 •
edited

I believe this improves developer experience, and it's a pretty simple change, so I'm willing to champion this rule enhancement. We need 2 more 👍's from the team and we can mark this as accepted.

@mysticatea
Copy link
Member

👍

1 similar comment
@ilyavolodin
Copy link
Member

👍

@vitorbal vitorbal added accepted There is consensus among the team that this change meets the criteria for inclusion and removed evaluating The team will evaluate this issue to decide whether it meets the criteria for inclusion labels Aug 4, 2016
jrencz added a commit to jrencz/eslint that referenced this issue Aug 4, 2016
@jrencz
Update: make max-lines report the actual number of lines (fixes esl…
62e0b01 
…int#6766)

Instead of reporting only that `max` value has been exceeded
it now also reports how many lines there is in the file.
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion enhancement This change enhances an existing feature of ESLint rule Relates to ESLint's core rules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@platinumazure @vitorbal @jrencz @ilyavolodin @mysticatea @eslintbot