camelcase lint error on module import when deconstructing

[lordgiotto]

ESLint version:

3.1.1

---

Rule:

"camelcase": [2, { "properties": "never" }]

---

Problem

Lint fails on module import when deconstructing properties and aliasing.

// this cause lint error
import { no_camel_case_prop as CamelCaseProp } from 'external-module';

But with 186e8f0 that rule should ignore camelcase during deconstructing.

(I know that import deconstructing is not a real object deconstructing, but probably it should follow the same rule)

For now I have to workaround this issue this way:

// this not cause lint error
import * as externalModule from 'external-module';
externalModule.no_camel_case_prop

---

Thank you :)

[vitorbal]

Hi @lordgiotto, thanks for reaching out!

Just verified that this is true. Even without the properties option set to never, I would expect the example code to not cause a lint error, for the same reasons outlined in #3185 for object destructuring.

So, to recap:

Valid:

/* eslint camelcase: 2*/
import { no_camel_case_prop as CamelCaseProp } from 'external-module';

Invalid:

/* eslint camelcase: 2*/
import { no_camel_case_prop } from 'external-module';

Invalid:

/* eslint camelcase: 2*/
import { no_camel_case_prop as no_camel_case_prop } from 'external-module';

@lordgiotto Would this be something you are willing to send a PR for?

[michaelficarra]

@lordgiotto The workaround you listed is wrong. It would be

import * as externalModule from 'external-module';
externalModule.no_camel_case_prop;

[lordgiotto]

@michaelficarra Oh, sorry, you're right! I fix it now.

@vitorbal It would be a pleasure, but to be honest I never read ESLint source code and I should at least study how it's designed before be able to send a PR. So I could do it, but i would need some time :P

[lordgiotto]

@vitorbal PR done :)