New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no-unused-vars
message does not end with a period
#6738
Comments
The other rules in ESLint seem to end their messages with a period, but `no-unused-vars` doesn't, so this PR attempts to change that.
Just to avoid potential confusion for people who use the most common formatter, "stylish", it's worth noting that the "stylish" formatter explicitly strips periods off the end of messages. My opinion is that we should still end lint messages with periods in general, because most or all other formatters carry those through. @wavebeem Thanks very much for the issue and for submitting a pull request to address! EDIT: Confirmed in online demo, which does not strip periods from messages. |
@platinumazure Oh, that's a good thing to call out! I was wondering why this wasn't noticed sooner, and that makes sense. I found this while making a tool that wraps ESLint, so I might have to copy that approach of trimming final periods! |
@wavebeem do you want to submit a PR for this? |
The other rules in ESLint seem to end their messages with a period, but `no-unused-vars` doesn't, so this PR attempts to change that.
What version of ESLint are you using?
2.10.2
What parser (default, Babel-ESLint, etc.) are you using?
Default
Please show your full configuration:
What did you do? Please include the actual source code causing the issue.
I linted code and got back a message without a period.
What did you expect to happen?
I expected the message from the
no-unused-vars
rule to include a period at the end, like the other messages from ESLint.What actually happened? Please include the actual, raw output from ESLint.
https://gist.github.com/wavebeem/98136a4d2823a43716e76651571473a6
The text was updated successfully, but these errors were encountered: