Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Missing step in Pull Requests guide #6595

Closed
theawesomenayak opened this issue Jul 4, 2016 · 1 comment
Closed

Docs: Missing step in Pull Requests guide #6595

theawesomenayak opened this issue Jul 4, 2016 · 1 comment
Assignees
@nzakas
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation

Comments

@theawesomenayak
Copy link

http://eslint.org/docs/developer-guide/contributing/pull-requests#step4

There is no Step 5. It's missing the part where you would push to the repository.
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Jul 4, 2016
@theawesomenayak theawesomenayak mentioned this issue Jul 4, 2016
Closed
@nzakas
Copy link
Member

nzakas commented Jul 4, 2016

Oops, good catch.

@nzakas nzakas added bug ESLint is working incorrectly documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jul 4, 2016
@nzakas nzakas self-assigned this Jul 4, 2016
nzakas added a commit that referenced this issue Jul 4, 2016
@nzakas
Docs: Add missing pull request step (fixes #6595)
bc9e44c
nzakas added a commit that referenced this issue Jul 4, 2016
@nzakas
Docs: Add missing pull request step (fixes #6595)
2941acc
nzakas added a commit that referenced this issue Jul 4, 2016
@nzakas
Docs: Add missing pull request step (fixes #6595)
0a8509b
nzakas added a commit that referenced this issue Jul 4, 2016
@nzakas
Docs: Add missing pull request step (fixes #6595)
1459113
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nzakas nzakas

Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion bug ESLint is working incorrectly documentation Relates to ESLint's documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nzakas @theawesomenayak @eslintbot