Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

documentation shows incorrect "outerIIFEBody" option values for indent rule #6581

Closed
SpadeAceman opened this issue Jul 2, 2016 · 0 comments
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules

Comments

@SpadeAceman
Copy link

What version of ESLint are you using?

3.0.0

What parser (default, Babel-ESLint, etc.) are you using?

default

Please show your full configuration:

{ "rules": {"indent":["warn","tab",{"outerIIFEBody":false}]}}

What did you do? Please include the actual source code causing the issue.

Linted a file – the source code is irrelevant, as the error happens for any code file.

What did you expect to happen?

The file should have been successfully linted.

What actually happened? Please include the actual, raw output from ESLint.

The file was not successfully linted, and ESLint abended with the error message below shown twice:

Configuration for rule "indent" is invalid:
Value "false" is the wrong type.

After reviewing the discussion in #6259, it looks like the rule was changed to accept numeric values for "outerIIFEBody", but the documentation retains the original approach of using boolean values. So it looks like it's just the documentation that needs updating – the configuration below works just fine:

{ "rules": {"indent":["warn","tab",{"outerIIFEBody":0}]}} // changed from false to 0
@eslintbot eslintbot added the triage An ESLint team member will look at this issue soon label Jul 2, 2016
@alberto alberto added rule Relates to ESLint's core rules documentation Relates to ESLint's documentation accepted There is consensus among the team that this change meets the criteria for inclusion and removed triage An ESLint team member will look at this issue soon labels Jul 3, 2016
pmcelhaney pushed a commit to pmcelhaney/eslint that referenced this issue Jul 4, 2016
@eslint-deprecated eslint-deprecated bot locked and limited conversation to collaborators Feb 6, 2018
@eslint-deprecated eslint-deprecated bot added the archived due to age This issue has been archived; please open a new issue for any further discussion label Feb 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
accepted There is consensus among the team that this change meets the criteria for inclusion archived due to age This issue has been archived; please open a new issue for any further discussion documentation Relates to ESLint's documentation rule Relates to ESLint's core rules
Projects
None yet
Development

No branches or pull requests

3 participants